Visitar URL original
Add supported Luci builders for packages repo by keyonghan · Pull Request #184 · flutter/packages · GitHub
Skip to content

Add supported Luci builders for packages repo #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyonghan merged 5 commits into from
Aug 6, 2020
Merged

Add supported Luci builders for packages repo #184

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fea035e
add luci try builders
keyonghan Jul 28, 2020
ad2d562
add readme
keyonghan Jul 29, 2020
9e3ec30
add code to validate json contents
keyonghan Jul 31, 2020
16e6901
remove json check dart
keyonghan Aug 5, 2020
26866e2
use generic name
keyonghan Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add luci try builders
  • Loading branch information
@keyonghan
keyonghan committed Aug 5, 2020
commit fea035e2c8b0b59d6f8e1bc104c456da891d4a26
8 changes: 8 additions & 0 deletions dev/packages_try_builders.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{

@godofredoc godofredoc Aug 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the same paths in all the repos? e.g in the engine repo we are using ci/dev/... additionally let's use just try_builders.json to make the recipes code more generic.

@keyonghan keyonghan Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use the same path as well.
For engine, as suggested by Yuqian, I saved it to ci/dev.
For sdk, we already have dev. I am not sure if it is okay/good to create a ci from root.
For packages, no dev or ci at all. I guess we can create either way.
For cocoon, it is now in dev, but up to change.

So, it is engine and sdk. what do you think?

@godofredoc godofredoc Aug 5, 2020 •
edited by keyonghan
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\cc @goderbauer is it ok to add a new top level folder called dev in this repo? this is to use the same path for builder configurations across repos.

@goderbauer goderbauer Aug 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a dev folder in this repo sounds good.

"builders":[
{
"name":"fuchsia_ctl",
"repo":"packages"
}
]
}