Visitar URL original
[extension_google_sign_in_as_googleapis_auth] Update example... by kevmoo · Pull Request #311 · flutter/packages · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[extension_google_sign_in_as_googleapis_auth] Update example...
Make GoogleSignIn instance final
To use scope from the People API
Remove x bit from readme and pubspec.yaml
Add link to root repo README
  • Loading branch information
kevmoo committed Mar 14, 2021
commit 580e01dfcf81aa243567822aa9f8d660e475d52c
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ These are the available packages in this repository.
| Plugin | Pub |
|--------|-----|
| [animations](./packages/animations/) | [![pub package](https://img.shields.io/pub/v/animations.svg)](https://pub.dev/packages/animations) |
| [extension_google_sign_in_as_googleapis_auth](./packages/extension_google_sign_in_as_googleapis_auth/) | [![pub package](https://img.shields.io/pub/v/extension_google_sign_in_as_googleapis_auth.svg)](https://pub.dev/packages/extension_google_sign_in_as_googleapis_auth) |
| [fuchsia_ctl](./packages/fuchsia_ctl/) | [![pub package](https://img.shields.io/pub/v/fuchsia_ctl.svg)](https://pub.dev/packages/fuchsia_ctl) |
| [multicast_dns](./packages/multicast_dns/) | [![pub package](https://img.shields.io/pub/v/multicast_dns.svg)](https://pub.dev/packages/multicast_dns) |
| [palette_generator](./packages/palette_generator/) | [![pub package](https://img.shields.io/pub/v/palette_generator.svg)](https://pub.dartlang.org/packages/palette_generator) |
Expand Down
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@ import 'package:google_sign_in/google_sign_in.dart';
import 'package:extension_google_sign_in_as_googleapis_auth/extension_google_sign_in_as_googleapis_auth.dart';
import 'package:googleapis/people/v1.dart';

GoogleSignIn _googleSignIn = GoogleSignIn(
scopes: <String>[
'email',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email doesn't seem to be needed...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought both 'profile' and 'email' were required to sign in, but not seeing profile there is suspicious :P let me run this example real quick!

https://developers.google.com/identity/protocols/oauth2/scopes#google-sign-in

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

('profile', 'email' and 'openid' seem to get added by the google sign-in API automatically if absent from the original request, good!)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running it all weekend – no issues!

'https://www.googleapis.com/auth/contacts.readonly',
],
final GoogleSignIn _googleSignIn = GoogleSignIn(
scopes: <String>[PeopleServiceApi.contactsReadonlyScope],
);

void main() {
Expand Down
Empty file.