Visitar URL original
Enum support in Pigeon by GaryQian · Pull Request #331 · flutter/packages · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parse and generate enums
  • Loading branch information
GaryQian committed May 14, 2021
commit 5860ebc619ec52c844ebe968b26bd28f4883390e
2 changes: 1 addition & 1 deletion packages/pigeon/lib/dart_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ void generateDart(DartOptions opt, Root root, StringSink sink) {
indent.addln(
'${field.name} == null ? null : ${field.name}$unwrapOperator.encode();',
);
} else if (customEnumNames.contians(field.dataType)) {
} else if (customEnumNames.contains(field.dataType)) {
indent.addln(
'${field.name} == null ? null : ${field.name}.index;',
);
Expand Down
31 changes: 30 additions & 1 deletion packages/pigeon/lib/pigeon_lib.dart
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ class FlutterApi {
const FlutterApi();
}

class PigeonEnum {
const PigeonEnum();
}

/// Represents an error as a result of parsing and generating code.
class Error {
/// Parametric constructor for Error.
Expand Down Expand Up @@ -101,6 +105,18 @@ bool _isApi(ClassMirror classMirror) {
(_getHostApi(classMirror) != null || _isFlutterApi(classMirror));
}

bool _isEnum(ClassMirror classMirror) {
if (!classMirror.isEnum) {
return false;
}
for (final InstanceMirror instance in classMirror.metadata) {
if (instance.reflectee is PigeonEnum) {
return true;
}
}
return false;
}

HostApi? _getHostApi(ClassMirror apiMirror) {
for (final InstanceMirror instance in apiMirror.metadata) {
if (instance.reflectee is HostApi) {
Expand Down Expand Up @@ -223,12 +239,15 @@ class Pigeon {
/// Use reflection to parse the [types] provided.
ParseResults parse(List<Type> types) {
final Set<ClassMirror> classes = <ClassMirror>{};
final Set<ClassMirror> enums = <ClassMirror>{};
final List<ClassMirror> apis = <ClassMirror>[];

for (final Type type in types) {
final ClassMirror classMirror = reflectClass(type);
if (_isApi(classMirror)) {
apis.add(classMirror);
} else if (_isEnum(classMirror)) {
enums.add(classMirror);
} else {
classes.add(classMirror);
}
Expand Down Expand Up @@ -283,6 +302,16 @@ class Pigeon {
));
}

for (final ClassMirror enu in enums) {
List<String> members = <String>[];
// The first 3 declarations and last two are trimmed as they are innate to
// enums in Dart and are not user defined values.
for (int i = 3; i < enu.declarations.keys.length - 2; i++) {
members.add(MirrorSystem.getName(enu.declarations.keys.toList()[i]));
}
root.enums.add(Enum(name: MirrorSystem.getName(enu.simpleName), members: members));
}

final List<Error> validateErrors = _validateAst(root);
return ParseResults(root: root, errors: validateErrors);
}
Expand Down Expand Up @@ -438,7 +467,7 @@ options:
for (final LibraryMirror library
in currentMirrorSystem().libraries.values) {
for (final DeclarationMirror declaration in library.declarations.values) {
if (declaration is ClassMirror && _isApi(declaration)) {
if (declaration is ClassMirror && (_isApi(declaration) || _isEnum(declaration))) {
apis.add(declaration.reflectedType);
}
}
Expand Down