Visitar URL original
Material Fade Transition Configuration; showModal implementation by shihaohong · Pull Request #60 · flutter/packages · GitHub
Skip to content

Material Fade Transition Configuration; showModal implementation #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shihaohong merged 30 commits into from
Jan 16, 2020
Merged

Material Fade Transition Configuration; showModal implementation #60

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
11d2729
WIP - Fade transition for dialogs
Jan 6, 2020
7b276fe
WIP - Refactor to extend PopupRoute
Jan 6, 2020
b652352
Implement fade_transition.dart
Jan 10, 2020
f043bff
Simple test
Jan 10, 2020
4f32441
Newline
Jan 10, 2020
2c726e0
Remove unnecessary `settings` param, API wordsmithing
Jan 10, 2020
2acc1eb
dialog -> modal
Jan 10, 2020
b28aaf5
Minor modifications to FlutterLogoModal
Jan 10, 2020
88670c2
Make Dart formatter happy
Jan 10, 2020
e8a4530
WIP - generalize showModal function
Jan 13, 2020
b3030eb
API docs and code cleanup
Jan 13, 2020
7ff4a02
Address code review feedback
Jan 14, 2020
fd4b545
Fix doc to use SizedBox instead of Column and ConstrainedBox
Jan 14, 2020
b23ca9a
Remove erroneous comma and replace with semicolon
Jan 14, 2020
b16e820
Make formatter happy
Jan 14, 2020
733084b
WIP - test scaffolding
Jan 14, 2020
33a2f35
Add fade portion of forwards transition test
Jan 14, 2020
f9b17fe
Implement forwards and reverse test for fade transition
Jan 14, 2020
9733e0f
Implement animation interrupt test - Fix bug found from writing inter…
Jan 14, 2020
5845b3f
Implement state test for fade transition
Jan 14, 2020
8474d44
modal.dart tests, comments on fade_transition_test.dart
Jan 14, 2020
69a4191
Newline at end of modal_test.dart
Jan 14, 2020
3b50849
Make formatter happy
Jan 14, 2020
0aa7422
Merge branch 'master' of github.com:flutter/packages into fade-dialog
shihaohong Jan 16, 2020
45dd4bf
Code review feedback
shihaohong Jan 16, 2020
b812d34
Code cleanup
shihaohong Jan 16, 2020
64846d8
Make formatter happy
shihaohong Jan 16, 2020
614687c
abstract getters over constructor parameters
shihaohong Jan 16, 2020
a9968c7
Abstract getter -> constructor params
shihaohong Jan 16, 2020
ae78df8
Fix incorrect reverse transition duration in modal_test.dart
shihaohong Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove erroneous comma and replace with semicolon
  • Loading branch information
Shi Hao Hong
Shi Hao Hong committed Jan 14, 2020
commit b23ca9ad358ce952ecc58558cc441cacfcfb7bc0
2 changes: 1 addition & 1 deletion packages/animations/lib/src/fade_transition.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import 'utils/curves.dart';
/// context: context,
/// configuration: FadeTransitionConfiguration(),
/// builder: (BuildContext context) {
/// return _CenteredFlutterLogo(),
/// return _CenteredFlutterLogo();
/// },
/// );
/// },
Expand Down