Visitar URL original
Shared Axis Transition Fix by shihaohong · Pull Request #66 · flutter/packages · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests and example of shared axis transitions
  • Loading branch information
shihaohong committed Jan 18, 2020
commit ef0ed40fb157322ae4135590f44795077bb8482d
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class _SharedAxisTransitionDemoState extends State<SharedAxisTransitionDemo> {
Expanded(
child: PageTransitionSwitcher(
duration: const Duration(milliseconds: 300),
reverse: _isLoggedIn,
reverse: !_isLoggedIn,
transitionBuilder: (
Widget child,
Animation<double> animation,
Expand Down
16 changes: 8 additions & 8 deletions packages/animations/lib/src/shared_axis_transition.dart
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ class _SharedAxisTransitionState extends State<SharedAxisTransition> {
switch (_effectiveAnimationStatus) {
case AnimationStatus.forward:
case AnimationStatus.reverse:
return _ExitTransition(
animation: _flip(widget.animation),
return _BottomWidgetTransition(
animation: widget.animation,
transitionType: widget.transitionType,
child: child,
);
Expand All @@ -349,8 +349,8 @@ class _SharedAxisTransitionState extends State<SharedAxisTransition> {
switch (_effectiveSecondaryAnimationStatus) {
case AnimationStatus.forward:
case AnimationStatus.reverse:
return _EnterTransition(
animation: _flip(widget.secondaryAnimation),
return _TopWidgetTransition(
animation: widget.secondaryAnimation,
transitionType: widget.transitionType,
child: child,
);
Expand All @@ -366,8 +366,8 @@ class _SharedAxisTransitionState extends State<SharedAxisTransition> {
}
}

class _EnterTransition extends StatelessWidget {
const _EnterTransition({
class _BottomWidgetTransition extends StatelessWidget {
const _BottomWidgetTransition({
this.animation,
this.transitionType,
this.child,
Expand Down Expand Up @@ -431,8 +431,8 @@ class _EnterTransition extends StatelessWidget {
}
}

class _ExitTransition extends StatelessWidget {
const _ExitTransition({
class _TopWidgetTransition extends StatelessWidget {
const _TopWidgetTransition({
this.animation,
this.transitionType,
this.child,
Expand Down
Loading