Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dcea1d2 to
cca0a19
Compare
|
/gbcrun |
|
@Calpoog, I know this is still in draft form, but I wanted to run the build on it, to see how it goes. |
|
Hi @sfshaza2, I've kept this one in draft until the implementation side is complete. However, I've still got that one in draft. Is there a particular draft/non-draft order I should doing these PRs in? This is my first time, so not sure of the process :) |
|
No, this is fine, @Calpoog. I just wanted to see if the build/bot was copacetic, and it seems to be. :) |
|
@sfshaza2 should I take the flutter repo implementation PR out of draft? No activity over there for a bit. |
|
Hi @Calpoog! I went ahead and ran the tests on that PR. The thing is, reviewers often ignore a PR until it's out of draft mode. So, I leave that up to you. :D |
2 participants
Description of what this PR is changing or adding, and why:
Documents the proposed
environmentsubfield for Flutter asset declarations. The assets guide explains exact matching, AND semantics across variables, OR semantics for value lists, unset-variable behavior, and composition with flavor and platform conditions. The pubspec reference defines the field and includes scalar and list examples.Issues fixed by this PR (if any):
Supports flutter/flutter#166842.
PRs or commits this PR depends on (if any):
Blocked by flutter/flutter#192739. This documentation should remain draft until the framework feature is accepted and its release availability is known.
Validation
dart run dash_site --site=docs builddart run dash_site --site=docs check-link-referencesdart run dash_site --site=docs check-linkscheck-allalso completed tests and excerpt validation, but its analyzer process crashed while attempting to send analytics because the network connection was cancelled. Its format check reports three pre-existing unrelated Dart files.Presubmit checklist