Repository navigation
Cookbook design - #13964
Cookbook design#13964sfshaza2 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Flutter cookbook design examples and documentation files, focusing on style guide alignment, list formatting, link updates, and code simplifications (such as removing redundant generic type arguments). Feedback on the changes highlights an incorrect link for SingleChildScrollView pointing to {{site.cupertino_ui}} instead of the core Flutter API documentation, which would cause a broken link.
|
|
||
| [`CupertinoApp`]: {{site.cupertino_ui}}/CupertinoApp-class.html | ||
| [`showCupertinoSheet`]: {{site.cupertino_ui}}/showCupertinoSheet.html | ||
| [`SingleChildScrollView`]: {{site.cupertino_ui}}/SingleChildScrollView-class.html |
There was a problem hiding this comment.
The SingleChildScrollView widget is a standard Flutter widget from the core framework, not part of the decoupled cupertino_ui package. Linking it to {{site.cupertino_ui}} will result in a broken link (404) on the built website. It should be linked using {{site.api}}/flutter/widgets/SingleChildScrollView-class.html instead.
| [`SingleChildScrollView`]: {{site.cupertino_ui}}/SingleChildScrollView-class.html | |
| [`SingleChildScrollView`]: {{site.api}}/flutter/widgets/SingleChildScrollView-class.html |
References
- Prioritize fixing navigation, rendering, accessibility, or security defects, such as broken links. (link)
|
Staged preview of the updated docs.flutter.dev site (updated for commit a40d270): https://flutter-docs-prod--docs-pr13964-cookbook-design-zre23v3l.web.app |
MuthuGCodes
left a comment
MuthuGCodes
left a comment
There was a problem hiding this comment.
Thanks for refreshing the Design cookbook recipes, @sfshaza2 :)
lgtm with a nit note.
|
|
||
| <noscript> | ||
| <img src="/assets/images/docs/cookbook/orientation.webp" alt="Orientation Demo" class="site-mobile-screenshot" /> | ||
| <img src="/assets/images/docs/cookbook/orientation.png" alt="Orientation Demo" /> |
There was a problem hiding this comment.
Should this be /assets/images/docs/cookbook/orientation.webp?
The /assets/images/docs/cookbook/ directory doesn't seem to have the orientation.png format file.
| You might even want to give them an option to undo the action. | ||
|
|
||
| {:.site-mobile-screenshot} | ||
|  |
There was a problem hiding this comment.
Same note. The .png format file doesn't seem to exist in the /assets/images/docs/cookbook/ directory.
|
|
||
| <noscript> | ||
| <img src="/assets/images/docs/cookbook/tabs.webp" alt="Tabs Demo" class="site-mobile-screenshot" /> | ||
| <img src="/assets/images/docs/cookbook/tabs.png" alt="Tabs Demo" /> |
There was a problem hiding this comment.
Same note. The .png format file doesn't seem to exist in the /assets/images/docs/cookbook/ directory.
3 participants
Refreshing the Design recipes in the cookbook