Visitar URL original
Reduce delay to make build faster. Fix unsafe json serialization. by Thorium · Pull Request #2879 · fsprojects/FAKE · GitHub
Skip to content

Reduce delay to make build faster. Fix unsafe json serialization. - #2879

Merged
xperiandri merged 3 commits into
fsprojects:masterfrom
Thorium:maintenance
Oct 28, 2025
Merged

Reduce delay to make build faster. Fix unsafe json serialization.#2879
xperiandri merged 3 commits into
fsprojects:masterfrom
Thorium:maintenance

Conversation

@Thorium

@Thorium Thorium commented Oct 28, 2025

Copy link
Copy Markdown
Member

Just minor tweaks.

@github-actions

github-actions Bot commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

   12 files  ±0     12 suites  ±0   36m 28s ⏱️ + 3m 8s
  451 tests ±0    450 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 287 runs  ±0  1 284 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 13b3dbd. ± Comparison against base commit d7c71ed.

♻️ This comment has been updated with latest results.

@xperiandri
xperiandri requested a review from Copilot October 28, 2025 15:28
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves security and performance by updating deprecated cryptographic APIs, fixing insecure JSON deserialization, and reducing polling delays.

Key changes:

  • Replaces deprecated AesManaged with Aes.Create() in vault encryption
  • Adds secure JSON deserialization settings to prevent type name handling attacks
  • Reduces process wait polling interval from 1000ms to 100ms

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/app/Fake.Core.Vault/Vault.fs Updates AES encryption API and secures JSON deserialization with explicit settings
src/app/Fake.Core.Process/Process.fs Reduces process polling delay and removes BOM character

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app/Fake.Core.Vault/Vault.fs Resolved
Comment thread src/app/Fake.Core.Process/Process.fs Resolved
@Thorium
Update src/app/Fake.Core.Vault/Vault.fs
13b3dbd 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@xperiandri
xperiandri merged commit 74e1e6f into fsprojects:master Oct 28, 2025
@Numpsy Numpsy mentioned this pull request Nov 26, 2025
Open
@xperiandri xperiandri mentioned this pull request Oct 10, 2026
Merged
This was referenced Oct 12, 2026
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 30, 2026
Closed
Open
Closed
Closed
Open
This was referenced Nov 6, 2026
Open
Closed
Closed
Closed
Open
Open
Closed
Open
Closed
Closed
Closed
Open
Closed
Open
Open
Closed
Open
Open
Closed
Open
Open
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@xperiandri xperiandri xperiandri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thorium @xperiandri