Visitar URL original
Colors paket keywords by edhzsz · Pull Request #379 · fsprojects/FSharp.Formatting · GitHub
Skip to content

Colors paket keywords - #379

Merged
tpetricek merged 3 commits into
fsprojects:masterfrom
edhzsz:colors_paket_keywords
Jan 20, 2016
Merged

tpetricek merged 3 commits into
fsprojects:masterfrom
edhzsz:colors_paket_keywords

Conversation

@edhzsz

@edhzsz edhzsz commented Jan 19, 2016

Copy link
Copy Markdown
Contributor

Related to issue #262
On PR #349 @tpetricek said that it would be awesome to have colorization for Paket keywords so I implemented.
This PR:

  • Adds coloring to Paket keywords.
  • Adds some missing operators.
  • Adds Test cases for Paket coloring

Some keywords are also part of urls, so a small refactoring was done to be able to change the Regex builder from white-space separated keywords in order to restrict the recognition of this keywords.
Implemented test cases for paket coloring.

After this, Paket code blocks will look like
image

Edgar Hernandez and others added 2 commits January 19, 2016 14:12
Adds some missing operators.
Some keywords are also part of urls, so a small refactoring was done to be able to change the Regex builder from whitespace separated keywords in order to restrict the recognition of this keywords.
Implemented test cases for paket coloring.
@tpetricek

Copy link
Copy Markdown
Member

This seems to be breaking the CI - can you investigate? Looks just like some silly syntax issue :)

@edhzsz

edhzsz commented Jan 19, 2016

Copy link
Copy Markdown
Contributor Author

Sorry, I had some indentation problems in my tests. 😞

tpetricek added a commit that referenced this pull request Jan 20, 2016
@tpetricek
tpetricek merged commit 1a0e69e into fsprojects:master Jan 20, 2016
@tpetricek

Copy link
Copy Markdown
Member

No problem :) released in version 2.13.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants