Visitar URL original
Use F#10 for the main lib by gusty · Pull Request #614 · fsprojects/FSharpPlus · GitHub
Skip to content

Use F#10 for the main lib - #614

Draft
gusty wants to merge 17 commits into
masterfrom
gus/fsharp9
Draft

Use F#10 for the main lib#614
gusty wants to merge 17 commits into
masterfrom
gus/fsharp9

Conversation

@gusty

@gusty gusty commented Feb 2, 2025

Copy link
Copy Markdown
Member

With the introduction of F#9 there seems to be a breaking change in backwards compatibility.

Although we can't fix the compiler, we can produce a lib that will work when consumed from F#9, still targeting .net8

@gusty
gusty force-pushed the gus/fsharp9 branch 3 times, most recently from 475a5ed to 49c70bb Compare February 2, 2025 16:52
wallymathieu
wallymathieu reviewed Nov 16, 2025
View reviewed changes
Comment thread .github/workflows/dotnetcore.yml Resolved
@T-Gro T-Gro mentioned this pull request Nov 25, 2025
Closed
@gusty
gusty force-pushed the gus/fsharp9 branch 2 times, most recently from e213a85 to ce22ec7 Compare December 3, 2025 18:16
@wallymathieu wallymathieu changed the title Use F#9 for the main lib Use F#10 for the main lib Dec 20, 2025
wallymathieu
wallymathieu reviewed Dec 20, 2025
View reviewed changes
Comment thread src/FSharpPlus/FSharpPlus.fsproj
<DefineConstants Condition=" '$(Configuration)' == 'Test'">$(DefineConstants);TEST_TRACE</DefineConstants>
<DefineConstants Condition=" '$(Configuration)' == 'Fable'">$(DefineConstants);FABLE_COMPILER</DefineConstants>
<DefineConstants Condition=" '$(Configuration)' == 'Fable4'">$(DefineConstants);FABLE_COMPILER;FABLE_COMPILER_4</DefineConstants>
<TargetFramework>net8.0</TargetFramework>

@wallymathieu wallymathieu Dec 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use target framework net10?

@T-Gro

T-Gro commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

@wallymathieu , @gusty :

As part of fixing compiler regressions spotted in this PR, I was automatically running all targets and when successfully running them, I realized it also made an unintended push to gh-pages.

Would you mind having a look and reverting if needed?

@gusty

gusty commented Jan 17, 2026

Copy link
Copy Markdown
Member Author

Would you mind having a look and reverting if needed?

No worries, I just reverted. Thanks !

@bartelink bartelink mentioned this pull request Aug 12, 2026
Closed
@bartelink

bartelink commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Logged #681 re the SRTP/memoization issue (which still persists with the .NET 11 toolchain).

It's unclear to me at this point whether using the net8.0 nupkg but compiling the tests on .NET 10/11 will repro; my main aim is to unblock dotnet/fsharp#19785 resolved by dotnet/fsharp#20247

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallymathieu wallymathieu wallymathieu left review comments

Assignees

No one assigned

Labels

F#+ v2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gusty @T-Gro @bartelink @wallymathieu