Visitar URL original
ref(tests): Remove query* for anything except checking for non-existe… by matejminar · Pull Request #29517 · getsentry/sentry · GitHub
Skip to content

ref(tests): Remove query* for anything except checking for non-existe… - #29517

Merged
matejminar merged 1 commit into
masterfrom
ref/rtl-query
Oct 25, 2021
Merged

matejminar merged 1 commit into
masterfrom
ref/rtl-query

Conversation

@matejminar

Copy link
Copy Markdown
Member

…nce in RTL

The query* variants should be used only for asserting that an element cannot found.

The get* and find* variants will throw a more helpful error message if no element is found.

This is a follow-up to: #29312 and #29508

@matejminar
matejminar requested a review from a team October 22, 2021 16:53
@matejminar
matejminar merged commit b616491 into master Oct 25, 2021
@matejminar
matejminar deleted the ref/rtl-query branch October 25, 2021 08:34
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2021

This branch was successfully deployed

2 active deployments
Preview – storybook — 84c53066 Deployed Oct 22, 2021 by vercel[bot]
Preview – sentry — 84c53066 Deployed Oct 22, 2021 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants