Visitar URL original
Actions: Add new models for external actions/workflows by JarLob · Pull Request #22263 · github/codeql · GitHub
Skip to content

Actions: Add new models for external actions/workflows #22263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JarLob wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Actions: Add new models for external actions/workflows #22263

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
62e81cd
Support for the new model of external workflows and composite actions
JarLob Jul 17, 2026
9c4c1a4
Update tests for the latest changes in extractor
JarLob Jul 18, 2026
38ffa26
Format external Actions model support
JarLob Jul 30, 2026
f3f6b42
Add change note
JarLob Jul 31, 2026
52ee51b
Support self-repository external references
JarLob Jul 31, 2026
ae4ce2e
Merge github/main into feature/actions-external-workflow-models
JarLob Jul 31, 2026
558a0e0
Address QL-for-QL review findings
JarLob Jul 31, 2026
658a065
Document external Actions model helpers
JarLob Jul 31, 2026
d14f439
Add explanation for suffix(2)
JarLob Aug 4, 2026
66160b7
apply review suggestion
JarLob Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
apply review suggestion
  • Loading branch information
@JarLob
JarLob committed Aug 4, 2026
commit 66160b7ddec0adfc41f7bedcd7a9090ac3eb0f64
9 changes: 5 additions & 4 deletions actions/ql/lib/codeql/actions/ast/internal/Ast.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,11 @@ class ExpressionImpl extends AstNodeImpl, TExpressionNode {

bindingset[owner, repo, action_path]
private string externalCompositeActionName(string owner, string repo, string action_path) {
action_path.trim() = "" and result = owner.trim() + "/" + repo.trim()
or
not action_path.trim() = "" and
result = owner.trim() + "/" + repo.trim() + "/" + action_path.trim()
exists(string trimmed_path | trimmed_path = action_path.trim() |
if trimmed_path = ""
then result = owner.trim() + "/" + repo.trim()
else result = owner.trim() + "/" + repo.trim() + "/" + trimmed_path
)
}

class CompositeActionImpl extends AstNodeImpl, TCompositeAction {
Expand Down
Loading