Visitar URL original
Remove MismatchedBranches check from code scanning workflow validation by shaikhul · Pull Request #1675 · github/codeql-action · GitHub
Skip to content

Remove MismatchedBranches check from code scanning workflow validation - #1675

Merged
henrymercer merged 7 commits into
github:mainfrom
shaikhul:remove-consts
May 11, 2023
Merged

Remove MismatchedBranches check from code scanning workflow validation#1675
henrymercer merged 7 commits into
github:mainfrom
shaikhul:remove-consts

Conversation

@shaikhul

@shaikhul shaikhul commented May 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Remove MismatchedBranches check from code scanning workflow validation as these two have misleading wording.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@shaikhul
shaikhul requested a review from a team as a code owner May 9, 2023 14:44
@shaikhul
shaikhul requested a review from henrymercer May 9, 2023 14:55
henrymercer
henrymercer previously approved these changes May 10, 2023
View reviewed changes
Comment thread src/workflow.test.ts Resolved
@henrymercer

henrymercer commented May 10, 2023

Copy link
Copy Markdown
Contributor

My understanding is that the main change of this PR is to remove the checks for push triggers in code scanning workflows, since with the simplified diff approach this is no longer required. If that's right, could we update the PR title / description accordingly? We may also want to add a brief changelog note in CHANGELOG.md. This will make it easier to find this PR in the future.

@shaikhul shaikhul changed the title Remove consts MismatchedBranches and MissingPushHook Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation May 10, 2023
@shaikhul
shaikhul requested a review from henrymercer May 10, 2023 15:03
@shaikhul shaikhul changed the title Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation Remove MismatchedBranches check from code scanning workflow validation May 10, 2023
henrymercer
henrymercer previously approved these changes May 11, 2023
View reviewed changes
Comment thread src/workflow.ts Resolved
Comment thread CHANGELOG.md Resolved
@shaikhul @henrymercer
Apply suggestions from code review
e5fdcd4 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@shaikhul
shaikhul requested a review from henrymercer May 11, 2023 14:08
@henrymercer

henrymercer commented May 11, 2023

Copy link
Copy Markdown
Contributor

@shaikhul Would you mind recompiling the Action and pushing again? 🙏 Unfortunately for now we need to check in the compiled code.

@shaikhul

shaikhul commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

@henrymercer done 903cb27

henrymercer
henrymercer previously approved these changes May 11, 2023
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One fix to the changelog format I didn't notice before, otherwise this is good to go!

Comment thread CHANGELOG.md Resolved
@shaikhul @henrymercer
Update CHANGELOG.md
a0755a7 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@henrymercer
henrymercer enabled auto-merge May 11, 2023 14:23
@henrymercer
henrymercer merged commit 130884e into github:main May 11, 2023
@github-actions github-actions Bot mentioned this pull request May 24, 2023
Merged
5 of 6 tasks
@atc0005 atc0005 mentioned this pull request May 25, 2023
Closed
26 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shaikhul @henrymercer