Visitar URL original
Add better error messages when determining merge-base by aeisenberg · Pull Request #1860 · github/codeql-action · GitHub
Skip to content

Add better error messages when determining merge-base - #1860

Merged
aeisenberg merged 4 commits into
mainfrom
aeisenberg/better-error-messages
Aug 29, 2023
Merged

Add better error messages when determining merge-base#1860
aeisenberg merged 4 commits into
mainfrom
aeisenberg/better-error-messages

Conversation

@aeisenberg

@aeisenberg aeisenberg commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Avoid printing scary error messages to console when the current directory is not a git repo. Instead provide a better reason for the git failure and continue on.

Fixes #1162.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg
aeisenberg requested a review from a team as a code owner August 28, 2023 19:29
@aeisenberg
aeisenberg force-pushed the aeisenberg/better-error-messages branch 6 times, most recently from 723ff68 to eb92954 Compare August 28, 2023 22:35
@aeisenberg
Add better error messages when determining merge-base
d721f69 
Avoid printing scary error messages to console when the current
directory is not a git repo. Instead provide a better reason for the git
failure and continue on.
@aeisenberg
aeisenberg force-pushed the aeisenberg/better-error-messages branch from eb92954 to d721f69 Compare August 28, 2023 22:50
github-advanced-security[bot]
github-advanced-security AI found potential problems Aug 28, 2023
View reviewed changes
Comment thread src/actions-util.test.ts Fixed
henrymercer
henrymercer reviewed Aug 29, 2023
View reviewed changes

@henrymercer henrymercer left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor suggestions. Also I've been suggesting we add changelog notes to more of our PRs and I think this one would benefit from one too.

Comment thread src/actions-util.test.ts Resolved
Comment thread src/actions-util.ts Resolved
Comment thread src/actions-util.ts Resolved
Comment thread src/actions-util.ts Resolved
Comment thread src/actions-util.test.ts Fixed
Comment thread src/actions-util.ts Resolved
henrymercer
henrymercer previously approved these changes Aug 29, 2023
View reviewed changes
Comment thread src/actions-util.test.ts Resolved
Comment thread src/actions-util.test.ts Resolved
Comment thread src/actions-util.ts Resolved
henrymercer
henrymercer approved these changes Aug 29, 2023
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for addressing this bit of customer feedback!

@aeisenberg
aeisenberg enabled auto-merge August 29, 2023 20:24
@aeisenberg
aeisenberg merged commit c5acfe3 into main Aug 29, 2023
@aeisenberg
aeisenberg deleted the aeisenberg/better-error-messages branch August 29, 2023 20:51
@github-actions github-actions Bot mentioned this pull request Sep 13, 2023
Merged
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid printing an error message when upload-sarif location is not a git directory

3 participants

@aeisenberg @henrymercer @github-advanced-security