Visitar URL original
Convert last remaining Python CI scripts to TypeScript by mbg · Pull Request #4043 · github/codeql-action · GitHub
Skip to content

Convert last remaining Python CI scripts to TypeScript - #4043

Merged
mbg merged 19 commits into
mainfrom
mbg/ts/changelog
Jul 28, 2026
Merged

Convert last remaining Python CI scripts to TypeScript#4043
mbg merged 19 commits into
mainfrom
mbg/ts/changelog

Conversation

@mbg

@mbg mbg commented Jul 24, 2026

Copy link
Copy Markdown
Member

This PR converts the last remaining Python scripts that are used in our CI to TypeScript equivalents.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - CI only.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Jul 24, 2026
@github-actions github-actions Bot added the size/XL May be very hard to review label Jul 24, 2026
@mbg
mbg force-pushed the mbg/ts/changelog branch from 79dbdef to 4b3c768 Compare July 24, 2026 15:02
mbg added 16 commits July 24, 2026 16:05
@mbg
Add NO_CHANGES_STR constant
2d14f71
@mbg
Add prepare-changelog.ts with tests
85d1570
@mbg
Update workflows to use prepare-changelog.ts
b69467c
@mbg
Remove prepare_changelog.py
5901394
@mbg
Add constant for unreleased placeholder
57eb441
@mbg
Add extractChangelogSnippet test for the case where there is no fir…
093dce6 
…st section
@mbg
Add parseChangelog and renderChangelog
916098a
@mbg
Update processChangelogForBackports to use parseChangelog
adba086
@mbg
Update extractChangelogSnippet to use parseChangelog
c5d6212
@mbg
Add bundle-changelog.ts with tests
66a6f42
@mbg
Use bundle-changelog.ts and remove Python version
027ac05
@mbg
Add rollback-changelog.ts with tests
d714617
@mbg
Use rollback-changelog.ts and remove Python version
961b583
@mbg
Remove python from CodeQL workflow
ab44eb9 
There is no more (non-test) Python code left to analyse, so CodeQL analysis would fail now
@mbg
Remove Python-specific steps from workflows that no longer need them
cbad145
@mbg
Add getErrorMessage to pr-checks-local util.ts to avoid pulling…
0953dc0 
… in `src/util.ts` dependencies
@mbg
mbg force-pushed the mbg/ts/changelog branch from 4b3c768 to 0953dc0 Compare July 24, 2026 15:08
@mbg
mbg requested a review from Copilot July 24, 2026 15:11
Copilot AI reviewed Jul 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Converts CI changelog tooling from Python to TypeScript and updates workflows accordingly.

Changes:

  • Adds TypeScript changelog utilities and tests.
  • Replaces Python script invocations with tsx.
  • Removes obsolete Python setup and scanning.
Show a summary per file
File Description
pr-checks/util.ts Adds error formatting helper.
pr-checks/rollback-changelog.ts Adds rollback changelog CLI.
pr-checks/rollback-changelog.test.ts Tests rollback generation.
pr-checks/prepare-changelog.ts Adds changelog extraction CLI.
pr-checks/prepare-changelog.test.ts Tests changelog extraction.
pr-checks/config.ts Adds bundle release URL prefix.
pr-checks/changelog.ts Adds parsing and rendering utilities.
pr-checks/changelog.test.ts Tests changelog round-tripping.
pr-checks/bundle-changelog.ts Adds bundle changelog CLI.
pr-checks/bundle-changelog.test.ts Tests bundle changelog behavior.
.github/workflows/update-supported-enterprise-server-versions.yml Removes unused Python setup.
.github/workflows/update-bundle.yml Uses TypeScript bundle script.
.github/workflows/script/rollback_changelog.py Removes superseded Python script.
.github/workflows/script/prepare_changelog.py Removes superseded Python script.
.github/workflows/script/bundle_changelog.py Removes superseded Python script.
.github/workflows/rollback-release.yml Uses TypeScript changelog scripts.
.github/workflows/post-release-mergeback.yml Uses TypeScript preparation script.
.github/workflows/codeql.yml Removes Python analysis.
.github/actions/release-initialise/action.yml Removes Python dependencies.

Review details

  • Files reviewed: 19/19 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread pr-checks/rollback-changelog.ts Resolved
Comment thread .github/workflows/post-release-mergeback.yml Resolved
@mbg
mbg marked this pull request as ready for review July 24, 2026 15:21
@mbg
mbg requested a review from a team as a code owner July 24, 2026 15:21
navntoft
navntoft previously approved these changes Jul 28, 2026
View reviewed changes

@navntoft navntoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(reviewed to the best of my ability as someone with limited knowledge about this codebase)

Looks well thought out and consistent with the rest of the codebase, as far as I can tell. Only two nits; your call on both.

Comment thread pr-checks/rollback-changelog.ts Resolved
Comment thread pr-checks/changelog.ts Resolved
@mbg @navntoft
Fix argument validation in rollback-changelog.ts
98c05a1 
Co-authored-by: Mads Navntoft <navntoft@github.com>
@mbg
mbg requested a review from navntoft July 28, 2026 10:58
@mbg
mbg added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 18420e3 Jul 28, 2026
222 checks passed
@mbg
mbg deleted the mbg/ts/changelog branch July 28, 2026 15:43
This was referenced Jul 29, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@navntoft navntoft navntoft approved these changes

Assignees

@mbg mbg

Labels

size/XL May be very hard to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbg @navntoft