Sandbox::https://github.com/github/github-mcp-server/pull/3394

SamMorrowDrums · 2026-10-02T13:44:37Z

Summary

Migrate all 16 remaining granular issue tools to concrete typed input/output registrations, preserving legacy text and exposing output schemas/structured content only for protocol 2026-07-28. Keep the already-typed hide/unhide tools unchanged.

Why

Continue the protocol-gated typed-tool migration above #3393, pinned to parent c3f5817fe2c0f87b778e0a9bc53af887059e72d3.
Fixes # N/A — stacked migration, not an issue closure.

What changed

Type create, single-field updates, custom fields, sub-issue mutations, and issue/comment reaction tools; retain input schemas, numeric coercions, confidence normalization, validation/errors, scopes and feature rules.
Reuse typed parent/sub-issue helpers, preserve nullable custom-field scalar outputs and exact API payloads, and add modern/legacy/unknown wire contracts plus schema snapshots.

MCP impact

No tool or API changes
Tool schema or behavior changed — modern clients receive concrete output schemas and structured content; legacy/unknown clients retain exact text without either. Existing input schemas remain unchanged.
New tool added

Prompts tested (tool changes only)

Automated MCP wire equivalents, not live natural-language sessions: create an issue under a cross-repository parent; update assignees/labels/type/state with suggestion metadata; set each custom field type; add/remove/reprioritize sub-issues; add/remove every supported issue/comment reaction; hide/unhide an issue comment.

Security / limits

No security or limits impact — no new endpoints or permissions.
Auth / permissions considered — repo scope, granular feature flags, read-only visibility and existing error handling retained and covered.
Data exposure, filtering, or token/size limits considered — reuse existing sub-issue sanitization; protocol-gated structured content mirrors legacy results.

Tool renaming

I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
- I have added the new tool aliases in deprecated_tool_aliases.go
I am not renaming tools as part of this PR

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

Linted locally with ./script/lint — script/lint passed, 0 issues.
Tested locally with ./script/test — script/test passed, full race suite.

Additional validation: UPDATE_TOOLSNAPS=true go test ./... passed; script/generate-docs passed with no documentation delta; git diff --check passed. Live PAT-backed e2e tests were not run. Signed coauthored commit 83955ca85c929687a0630503dcc061b1b9af4537.

Docs

Not needed — documentation generator completed; published inputs/tool descriptions did not change.
Updated (README / docs / examples)

Keep this PR draft. Stack metadata is intentionally untouched; the coordinator will append after verification.

Copilot

Copilot review overview

🔵 Needs a closer look

The broad compatibility-sensitive migration across 18 wire contracts warrants final human review despite extensive automated coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Migrates granular issue tools to typed inputs and protocol-gated structured outputs while preserving legacy wire behavior.

Changes:

Adds typed DTOs, normalization, and structured outputs for 16 issue tools.
Adds modern, legacy, error, visibility, and schema contract coverage.
Updates typed snapshots and consolidates the Windows license architecture sections.

File	Description
`pkg/github/issues_granular.go`	Registers typed granular issue handlers.
`pkg/github/granular_issue_types.go`	Defines DTOs, normalization, and output helpers.
`pkg/github/typed_granular_issue_outputs_test.go`	Tests protocol-gated wire contracts.
`pkg/github/__toolsnaps__/create_issue_typed.snap`	Captures typed create schema.
`pkg/github/__toolsnaps__/update_issue_title_typed.snap`	Captures title-update schema.
`pkg/github/__toolsnaps__/update_issue_body_typed.snap`	Captures body-update schema.
`pkg/github/__toolsnaps__/update_issue_assignees_typed.snap`	Captures assignee-update schema.
`pkg/github/__toolsnaps__/update_issue_labels_typed.snap`	Captures label-update schema.
`pkg/github/__toolsnaps__/update_issue_milestone_typed.snap`	Captures milestone-update schema.
`pkg/github/__toolsnaps__/update_issue_type_typed.snap`	Captures type-update schema.
`pkg/github/__toolsnaps__/update_issue_state_typed.snap`	Captures state-update schema.
`pkg/github/__toolsnaps__/add_sub_issue_typed.snap`	Captures add-sub-issue schema.
`pkg/github/__toolsnaps__/remove_sub_issue_typed.snap`	Captures remove-sub-issue schema.
`pkg/github/__toolsnaps__/reprioritize_sub_issue_typed.snap`	Captures reprioritization schema.
`pkg/github/__toolsnaps__/set_issue_fields_typed.snap`	Captures custom-field schema.
`pkg/github/__toolsnaps__/add_issue_reaction_typed.snap`	Captures issue-reaction schema.
`pkg/github/__toolsnaps__/remove_issue_reaction_typed.snap`	Captures reaction-removal schema.
`pkg/github/__toolsnaps__/add_issue_comment_reaction_typed.snap`	Captures comment-reaction schema.
`pkg/github/__toolsnaps__/remove_issue_comment_reaction_typed.snap`	Captures comment-reaction removal schema.
`pkg/github/__toolsnaps__/hide_issue_comment_typed.snap`	Captures comment-hide schema.
`pkg/github/__toolsnaps__/unhide_issue_comment_typed.snap`	Captures comment-unhide schema.
`third-party-licenses.windows.md`	Deduplicates identical architecture sections.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🔵 Needs a closer look

The broad protocol-dependent migration across 16 mutation tools warrants final human verification despite comprehensive contract tests.

Review effort: Balanced
Findings: None

Copilot

Copilot review overview

🟡 Changes recommended

Validation errors now gain wrapper text, breaking the stated legacy text compatibility.

Review effort: Balanced
Findings: 1

Open (1)

Preserve original validation messages in compatibility normalizers · New

+func normalizeGranularIssueUpdateArguments(field string) inventory.InputNormalizer {
+	return func(raw json.RawMessage) (json.RawMessage, error) {


Migrate the remaining 17 repository tools to concrete inputs and outputs. Preserve existing content, mutations, scopes, filtering, and protocol gating; add wire and schema conformance coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Replace raw REST output schemas with compact repository DTOs, retain one canonical snapshot per tool, and align modern JSON text with structured output while pinning legacy content. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Preserve raw helper APIs and exact legacy text while exposing concrete output unions for modern protocols. Retain explicit awaiting statuses and real null responses without exposing SDK-generated error fallbacks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Auto-generated by license-check workflow

Project compact method-discriminated DTOs from API responses while preserving the separate legacy text formatter and explicit app-awaiting status. Cache strict schemas and keep only canonical snapshots. Strengthen null-member presence, schema size, and lockdown projection regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Preserve forbidden variant properties as annotated schema objects rather than boolean schemas emitted by jsonschema-go. Cover Inspector's input paths and IFC labels on every issue-read method across protocols. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Reject unknown methods, states, field types, opaque values and API URL properties while covering nullable and empty method data. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Pin unchanged legacy profile/avatar fields separately from compact modern user projections and assert identical lockdown filtering and sanitization across protocols. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove added custom-field union constraints and sentinel enums from the advertised issue-write input. Preserve runtime exactly-one validation and private strict-schema tests. All three scoped input schemas compare exactly equal to main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Auto-generated by license-check workflow

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # pkg/github/__toolsnaps__/add_sub_issue.snap # pkg/github/__toolsnaps__/remove_sub_issue.snap # pkg/github/__toolsnaps__/reprioritize_sub_issue.snap # pkg/github/granular_issue_types.go # pkg/github/issues_granular.go # pkg/github/typed_granular_issue_outputs_test.go # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # interactive rebase in progress; onto 1973eee # Last command done (1 command done): # pick 5b8f9d19 # refactor(issues): minimize granular structured outputs # No commands remaining. # You are currently rebasing. # # Changes to be committed: # modified: pkg/github/__toolsnaps__/add_issue_comment_reaction.snap # modified: pkg/github/__toolsnaps__/add_issue_reaction.snap # modified: pkg/github/__toolsnaps__/add_sub_issue.snap # modified: pkg/github/__toolsnaps__/create_issue.snap # modified: pkg/github/__toolsnaps__/hide_issue_comment.snap # modified: pkg/github/__toolsnaps__/remove_issue_comment_reaction.snap # modified: pkg/github/__toolsnaps__/remove_issue_reaction.snap # modified: pkg/github/__toolsnaps__/remove_sub_issue.snap # modified: pkg/github/__toolsnaps__/reprioritize_sub_issue.snap # modified: pkg/github/__toolsnaps__/set_issue_fields.snap # modified: pkg/github/__toolsnaps__/unhide_issue_comment.snap # modified: pkg/github/__toolsnaps__/update_issue_assignees.snap # modified: pkg/github/__toolsnaps__/update_issue_body.snap # modified: pkg/github/__toolsnaps__/update_issue_labels.snap # modified: pkg/github/__toolsnaps__/update_issue_milestone.snap # modified: pkg/github/__toolsnaps__/update_issue_state.snap # modified: pkg/github/__toolsnaps__/update_issue_title.snap # modified: pkg/github/__toolsnaps__/update_issue_type.snap # modified: pkg/github/comment_minimize_test.go # new file: pkg/github/granular_issue_types.go # modified: pkg/github/granular_tools_test.go # modified: pkg/github/issues_granular.go # new file: pkg/github/typed_granular_issue_outputs_test.go #

The merge-base changed after approval.

SamMorrowDrums added this pull request to stack #3385 October 2, 2026 13:45

SamMorrowDrums mentioned this pull request Oct 2, 2026

refactor(search): type repository, user, org and commit search tools #3395

Merged

7 of 13 tasks

SamMorrowDrums force-pushed the sammorrowdrums-typed-granular-issue-tools branch from a6b1d69 to e0638ac Compare October 2, 2026 20:50

SamMorrowDrums requested a balanced review from Copilot October 3, 2026 04:33

Copilot started reviewing on behalf of SamMorrowDrums October 3, 2026 04:33 View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

SamMorrowDrums marked this pull request as ready for review October 5, 2026 10:26

SamMorrowDrums requested a review from a team as a code owner October 5, 2026 10:26

SamMorrowDrums force-pushed the sammorrowdrums-typed-granular-issue-tools branch from c82cea6 to 00fd1b4 Compare October 5, 2026 12:17

SamMorrowDrums requested a balanced review from Copilot October 5, 2026 12:17

Copilot started reviewing on behalf of SamMorrowDrums October 5, 2026 12:17 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

SamMorrowDrums requested a balanced review from Copilot October 5, 2026 12:23

Copilot started reviewing on behalf of SamMorrowDrums October 5, 2026 12:24 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread pkg/github/granular_issue_types.go

Comment on lines +253 to +254

func normalizeGranularIssueUpdateArguments(field string) inventory.InputNormalizer {

return func(raw json.RawMessage) (json.RawMessage, error) {

SamMorrowDrums force-pushed the sammorrowdrums-typed-granular-issue-tools branch from 00fd1b4 to c48e730 Compare October 6, 2026 16:12

kerobbi previously approved these changes Oct 6, 2026

View reviewed changes

SamMorrowDrums and others added 11 commits October 7, 2026 00:11

chore(repos): exclude unrelated snapshot formatting drift

ce2da89

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

chore: regenerate license files

d92f9ba

Auto-generated by license-check workflow

test(issues): cover strict sub-issue output variants

5be3afb

Reject unknown methods, states, field types, opaque values and API URL properties while covering nullable and empty method data. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

fix(issues): restore protocol output parity

881e2d4

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions Bot and others added 2 commits October 7, 2026 00:11

chore: regenerate license files

f4171db

Auto-generated by license-check workflow

SamMorrowDrums force-pushed the sammorrowdrums-typed-granular-issue-tools branch from c48e730 to e4d0b2f Compare October 6, 2026 22:11

Base automatically changed from sammorrowdrums-typed-consolidated-issue-tools to main October 6, 2026 22:13

SamMorrowDrums merged commit d6a8ac1 into main Oct 6, 2026
21 checks passed

SamMorrowDrums deleted the sammorrowdrums-typed-granular-issue-tools branch October 6, 2026 22:13

BrewTestBot mentioned this pull request Oct 7, 2026

github-mcp-server 2.0.0 Homebrew/homebrew-core#315987

Merged

Navigation Menu

Repository navigation

Type granular issue MCP inputs and protocol-gated outputs - #3394

Type granular issue MCP inputs and protocol-gated outputs#3394
SamMorrowDrums merged 13 commits into
mainfrom
sammorrowdrums-typed-granular-issue-tools

SamMorrowDrums commented Oct 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		func normalizeGranularIssueUpdateArguments(field string) inventory.InputNormalizer {
		return func(raw json.RawMessage) (json.RawMessage, error) {

Conversation

SamMorrowDrums commented Oct 2, 2026

Summary

Why

What changed

MCP impact

Prompts tested (tool changes only)

Security / limits

Tool renaming

Lint & tests

Docs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants