Visitar URL original
Add ability to add collaborator by mtscout6 · Pull Request #462 · github-tools/github · GitHub
Skip to content

Add ability to add collaborator #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtscout6 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add ability to add collaborator #462

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e0b9de
Add ability to add collaborator
mtscout6 Jul 16, 2017
d3a4373
Fix ESLint to work with async/await
mtscout6 Jul 16, 2017
03914f2
Update supported Node Versions
mtscout6 Jul 16, 2017
4fca61d
Cleanup page requests to use async / await
mtscout6 Jul 16, 2017
699d092
Convert rateLimit test to async / await
mtscout6 Jul 16, 2017
c5c3060
Fix failing test
mtscout6 Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert rateLimit test to async / await
  • Loading branch information
@mtscout6
mtscout6 committed Jul 16, 2017
commit 699d092e3240f0da78f37e2739bbef1111ee1d2e
22 changes: 9 additions & 13 deletions test/rate-limit.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import expect from 'must';

import Github from '../lib/GitHub';
import testUser from './fixtures/user.json';
import {assertSuccessful} from './helpers/callbacks';

describe('RateLimit', function() {
let github;
Expand All @@ -18,18 +17,15 @@ describe('RateLimit', function() {
rateLimit = github.getRateLimit();
});

it('should get rate limit', function(done) {
rateLimit.getRateLimit(assertSuccessful(done, function(err, rateInfo) {
const rate = rateInfo.rate;
it('should get rate limit', async function() {
const {data: rateInfo} = await rateLimit.getRateLimit();
const rate = rateInfo.rate;

expect(rate).to.be.an.object();
expect(rate).to.have.own('limit');
expect(rate).to.have.own('remaining');
expect(rate.limit).to.be.a.number();
expect(rate.remaining).to.be.a.number();
expect(rate.remaining).to.be.at.most(rateInfo.rate.limit);

done();
}));
expect(rate).to.be.an.object();
expect(rate).to.have.own('limit');
expect(rate).to.have.own('remaining');
expect(rate.limit).to.be.a.number();
expect(rate.remaining).to.be.a.number();
expect(rate.remaining).to.be.at.most(rateInfo.rate.limit);
});
});