Visitar URL original
Configuration file not used with "gren release", but works with "gren changelog" · Issue #110 · github-tools/github-release-notes · GitHub
Skip to content

Configuration file not used with "gren release", but works with "gren changelog" #110

Closed

Description

@ebousse

To avoid having to always write the option --data-source=commits, I have created a configuration file called .grenrc.json with this content:

{
    "dataSource": "commits"
}

Then in the same folder I try to do a github release, and we see that it only searches for issues, not commits, therefore creating a release with 0 issues (because there is none):

$ gren release --override             

🤖  - Generate release notes:
===================================

Getting the list of releases : ...... (0.53 secs)
1 releases found

Getting tags : .... (0.35 secs)
Tags found: 2.4.0

Getting the tag dates ranges : .... (0.32 secs)
Creating the body blocks from releases:

Getting all closed issues : ...... (0.54 secs)
2.4.0 has 0 issues found	

Updating latest release : .... (0.34 secs)

2.4.0 has been successfully updated!

But if I do a git changelog, it does use the configuration file, because it correctly creates the list of commits in CHANGELOG.md.

Am I missing something?

thanks for your tool!

Activity

  1. self-assigned this
    on Oct 20, 2017
  2. alexcanessa commented on Oct 20, 2017

    @alexcanessa
    Member

    @ebousse mmh.. 😕 let me investigate this and I'll come back to you 👍

  3. ebousse commented on Nov 3, 2017

    @ebousse
    Author

    thanks! I'll give it a try ASAP

  4. alexcanessa commented on Nov 3, 2017

    @alexcanessa
    Member

    @ebousse brilliant, thanks. Let me know.

  5. added this to the Release 0.13.1 milestone on Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions