Visitar URL original
Fix configuration file options being overwritten by alexcanessa · Pull Request #113 · github-tools/github-release-notes · GitHub
Skip to content

Fix configuration file options being overwritten - #113

Merged
alexcanessa merged 2 commits into
masterfrom
fix-config-read
Nov 2, 2017
Merged

alexcanessa merged 2 commits into
masterfrom
fix-config-read

Conversation

@alexcanessa

Copy link
Copy Markdown
Member

Program.js was using its defaults as properties passed, which then overwrote the configuration file.

Fixes #110

@codecov-io

codecov-io commented Nov 2, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files           7        7           
  Lines         293      293           
=======================================
  Hits          253      253           
  Misses         40       40
Impacted Files Coverage Δ
lib/src/Program.js 82.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53558f5...584d713. Read the comment docs.

@alexcanessa
alexcanessa merged commit 5800bf4 into master Nov 2, 2017
@alexcanessa
alexcanessa deleted the fix-config-read branch November 2, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants