Visitar URL original
Remove unused user.name option by alexcanessa · Pull Request #46 · github-tools/github-release-notes · GitHub
Skip to content

Remove unused user.name option #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcanessa merged 1 commit into from
Mar 13, 2017
Merged

Remove unused user.name option #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/github-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,6 @@ function executeCommand(command, callback) {
});
}

/**
* Get user informations
*
* @since 0.5.0
* @public
*
* @param {Function} callback
*
* @return {Promise} The promise that resolves user informations ({ user: username})
*/
function user(callback) {
return executeCommand('git config user.name', function(user) {
return {
user: user
};
})
.then(callback);
}

/**
* Get repo informations
*
Expand Down Expand Up @@ -96,7 +77,6 @@ function token(callback) {
}

module.exports = {
user: user,
repo: repo,
token: token
};
1 change: 0 additions & 1 deletion src/gren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,6 @@ function createChangelog(gren, body) {
*/
function generateOptions(options) {
return Promise.all([
options.user ? Promise.resolve(options.user) : githubInfo.user(),
options.repo ? Promise.resolve(options.repo) : githubInfo.repo(),
options.token ? Promise.resolve(options.token) : githubInfo.token()
]);
Expand Down