Repository navigation
fix(memory): apply rewinds to incremental events - #8138
Draft
1aifanatic wants to merge 1 commit into
Draft
1aifanatic wants to merge 1 commit into
1aifanatic wants to merge 1 commit into
Conversation
Signed-off-by: Naveen Chatlapalli <naveen.aifanatic@gmail.com>
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Closes #8137
Incremental memory ingestion currently drops contentless rewind events and keeps recalling the undone turns. Resolve rewinds over the combined history and retain invocation boundaries needed to locate their targets. Deleted entries retain only a content-free anchor, never their deleted payload. This also supports a delta rewind after an initial full-session ingestion.
Testing Plan
python -m pytest tests/unittests/memory/test_in_memory_memory_service.py -q: 70 passed.rewind_async, ingest only the new rewind event, search memory. Output:before rewind=1, after=0, kept=1. No model calls or mocked Runner components.git diff --checkchecked locally; Windows shell-wrapper check run through its Python entry point.Checklist
Prepared with AI assistance. Existing private-storage assertions were updated to include contentless invocation anchors; user-visible memory search assertions remain intact.