Visitar URL original
add transformAsync and bump version to 1.0.1 by pongad · Pull Request #28 · googleapis/api-common-java · GitHub
Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

add transformAsync and bump version to 1.0.1 - #28

Merged
pongad merged 4 commits into
googleapis:masterfrom
pongad:transform-async
May 10, 2017
Merged

add transformAsync and bump version to 1.0.1#28
pongad merged 4 commits into
googleapis:masterfrom
pongad:transform-async

Conversation

@pongad

@pongad pongad commented May 10, 2017

Copy link
Copy Markdown
Contributor

No description provided.

pongad
pongad commented May 10, 2017
View reviewed changes
Comment thread src/main/java/com/google/api/core/ApiFutures.java
}

public static <I, O> ApiFuture<O> transformAsync(
ApiFuture<I> input, final ApiAsyncFunction<I, O> function) {

This comment was marked as spam.

Sign in to view

@codecov-io

codecov-io commented May 10, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #28 into master will increase coverage by 2.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
+ Coverage     56.61%   58.72%   +2.11%     
- Complexity      126      133       +7     
============================================
  Files            15       15              
  Lines           590      596       +6     
  Branches         91       91              
============================================
+ Hits            334      350      +16     
+ Misses          233      224       -9     
+ Partials         23       22       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/google/api/core/ApiFutures.java 89.18% <100%> (+11.76%) 8 <1> (+3) ⬆️
...m/google/api/core/ApiFutureToListenableFuture.java 70% <0%> (+70%) 4% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6275504...26d7af7. Read the comment docs.

@pongad pongad mentioned this pull request May 10, 2017
Merged
garrettjonesgoogle
garrettjonesgoogle reviewed May 10, 2017
View reviewed changes
Comment thread version.txt
@@ -1 +1 @@
1.0.0

This comment was marked as spam.

Sign in to view

michaelbausor
michaelbausor reviewed May 10, 2017
View reviewed changes

@michaelbausor michaelbausor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after version change

garrettjonesgoogle
garrettjonesgoogle reviewed May 10, 2017
View reviewed changes
Comment thread src/main/java/com/google/api/core/ApiAsyncFunction.java Outdated
*
* <p>It is similar to Guava's {@code AsyncFunction}, redeclared so that Guava can be shaded.
*/
public interface ApiAsyncFunction<F, T> {

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle

garrettjonesgoogle commented May 10, 2017

Copy link
Copy Markdown
Contributor

LGTM after you update the commit description.

@pongad
pongad merged commit c3c17c5 into googleapis:master May 10, 2017
@pongad
pongad deleted the transform-async branch May 10, 2017 23:06
pongad added a commit to googleapis/google-cloud-java that referenced this pull request May 11, 2017
@pongad
bump version of api-common to 1.1.0 (#2048)
3d87984 
This brings in the change in
googleapis/api-common-java#28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments
@michaelbausor michaelbausor michaelbausor left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @codecov-io @garrettjonesgoogle @michaelbausor