Visitar URL original
Fix type annotation for `request` to indicate it can also be a dictionary · Issue #715 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Fix type annotation for request to indicate it can also be a dictionary #715

Closed
Closed
Fix type annotation for request to indicate it can also be a dictionary#715
Labels
🚨This issue needs some love.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@busunkim96
busunkim96
opened on Dec 18, 2020

https://github.com/googleapis/python-secret-manager/blob/dee9bd0ee381528476e8f6f1755b713238b1f1be/google/cloud/secretmanager_v1beta1/services/secret_manager_service/client.py#L277-L285

    def list_secrets(
        self,
        request: service.ListSecretsRequest = None,
        *,
        parent: str = None,
        retry: retries.Retry = gapic_v1.method.DEFAULT,
        timeout: float = None,
        metadata: Sequence[Tuple[str, str]] = (),
    ) -> pagers.ListSecretsPager:

Activity

  1. busunkim96
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Dec 18, 2020
  2. yoshi-automation
    added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on Mar 18, 2021
  3. yoshi-automation
    added
    🚨This issue needs some love.
    on Jun 16, 2021

  4. busunkim96 commented on Sep 13, 2021

    @busunkim96
    busunkim96
    on Sep 13, 2021
    ContributorAuthor

    Fixed in #966

  5. busunkim96
    closed this as completedon Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🚨This issue needs some love.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions