Visitar URL original
feat: add support for long-running operations with rest transport. by kbandes · Pull Request #1094 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

feat: add support for long-running operations with rest transport. - #1094

Merged
kbandes merged 8 commits into
googleapis:masterfrom
kbandes:kbandes-lro
Nov 25, 2021
Merged

feat: add support for long-running operations with rest transport.#1094
kbandes merged 8 commits into
googleapis:masterfrom
kbandes:kbandes-lro

Conversation

@kbandes

@kbandes kbandes commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

This PR adds support for long-running operations in the rest transport. Some noteworthy points:

  • the python gapic generator now reads the service yaml file for an api, using a new service_yaml parameter in py_gapic_library targets. The content of this file is loaded into a google.api.Service proto and is available in the schema as the API.service_yaml_config property. This can, in the future, support other features that rely on information in this file. Note that the java, golang, php, and nodejs targets already have this parameter.

  • In addition to unit tests, this change has been tested against a live server using the cloud translate api.
    Note that this change is dependent upon feat: add operations rest client to support long-running operations. python-api-core#311.

@kbandes
kbandes requested review from a team November 19, 2021 00:46
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
parthea
parthea reviewed Nov 19, 2021
View reviewed changes

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations

Comment thread gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 Resolved
Comment thread gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 Resolved
kbandes and others added 2 commits November 20, 2021 09:02
@kbandes @parthea
Update gapic/templates/%namespace/%name_%version/%sub/services/%servi…
cf674eb 
…ce/transports/rest.py.j2

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@kbandes @parthea
Update gapic/templates/%namespace/%name_%version/%sub/services/%servi…
cd8eb85 
…ce/transports/rest.py.j2

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
software-dov
software-dov reviewed Nov 22, 2021
View reviewed changes
Comment thread gapic/schema/api.py Resolved
Comment thread gapic/utils/options.py Resolved
@software-dov

software-dov commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

Looks good, just two minor nits that shouldn't block the merge. Feel free to integrate them or ignore them.

@kbandes

kbandes commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

I'll take a look. In some cases the only way I could resolve conflicts between black and flake8 was to remove trailing commas, but that was a different repo. I'll try it.

@kbandes

kbandes commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

I need to make additional changes:

  1. OperationsRestClient has been renamed to AbstractOperationsClient.
  2. The generated tests for rest now fail, I think because the Operations rest transport is not being mocked.

@kbandes
kbandes merged commit e89fd23 into googleapis:master Nov 25, 2021
@kbandes
kbandes deleted the kbandes-lro branch November 25, 2021 02:19
gcf-merge-on-green Bot pushed a commit that referenced this pull request Dec 8, 2021
@release-please
chore: release 0.58.0 (#1097)
6d78f5e 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.58.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.57.0...v0.58.0) (2021-12-07)


### Features

* add support for long-running operations with rest transport. ([#1094](https://www.github.com/googleapis/gapic-generator-python/issues/1094)) ([e89fd23](https://www.github.com/googleapis/gapic-generator-python/commit/e89fd23609625c5aa49acd6c6ee67f87fce324fd))


### Bug Fixes

* ensure rest unit tests have complete coverage ([#1098](https://www.github.com/googleapis/gapic-generator-python/issues/1098)) ([0705d9c](https://www.github.com/googleapis/gapic-generator-python/commit/0705d9c5dbbea793867551e64991be37d8339c6b))
* fix resource path args for paths with =** ([#1089](https://www.github.com/googleapis/gapic-generator-python/issues/1089)) ([309cc66](https://www.github.com/googleapis/gapic-generator-python/commit/309cc66e880e07940866864b03c744310ef56762))
* **snippetgen:** don't create duplicate requests for required oneofs ([#1088](https://www.github.com/googleapis/gapic-generator-python/issues/1088)) ([5531795](https://www.github.com/googleapis/gapic-generator-python/commit/55317956397370a91b1a06ecd476e55f58789807))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@parthea parthea mentioned this pull request Dec 9, 2021
Merged
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@parthea parthea parthea left review comments
@software-dov software-dov software-dov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbandes @software-dov @parthea