Visitar URL original
chore: refactor wrap method helper into a macro by ohmayr · Pull Request #2111 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

chore: refactor wrap method helper into a macro - #2111

Merged
ohmayr merged 6 commits into
mainfrom
refactor-wrap-method-macro
Aug 30, 2024
Merged

chore: refactor wrap method helper into a macro#2111
ohmayr merged 6 commits into
mainfrom
refactor-wrap-method-macro

Conversation

@ohmayr

@ohmayr ohmayr commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

This PR does the following:

  • adds a kind property to async gRPC transport similar to sync gRPC.
  • implements a macro to call _prep_wrapped_messages; can be re-used for async REST.
  • implements a macro to add a helper for conditionally calling wrap_method with the kind property configured.

@ohmayr
ohmayr requested a review from a team August 28, 2024 18:38
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Aug 28, 2024
@ohmayr
ohmayr force-pushed the refactor-wrap-method-macro branch from cae7e99 to 94a46f4 Compare August 28, 2024 18:38
@ohmayr
ohmayr force-pushed the refactor-wrap-method-macro branch from 8c77cc0 to af98897 Compare August 28, 2024 19:33
vchudnov-g
vchudnov-g suggested changes Aug 29, 2024
View reviewed changes
Comment thread ...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py Resolved
Comment thread gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Resolved
vchudnov-g
vchudnov-g reviewed Aug 29, 2024
View reviewed changes
Comment thread ...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py Resolved
Comment thread gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Resolved
Comment thread gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2 Resolved
vchudnov-g
vchudnov-g approved these changes Aug 29, 2024
View reviewed changes

@vchudnov-g vchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please address the comments here about enforcing macro contracts, but otherwise LGTM now. Thanks for working on this and answering my questions!

@ohmayr

ohmayr commented Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

OK, please address the comments here about enforcing macro contracts, but otherwise LGTM now. Thanks for working on this and answering my questions!

I've updated the contract and will shortly be merging this. Thanks for the feedback!

@ohmayr ohmayr changed the title chore: refactor wrapping method helper into a macro chore: refactor wrapping wrap helper into a macro Aug 30, 2024
@ohmayr ohmayr changed the title chore: refactor wrapping wrap helper into a macro chore: refactor wrap method helper into a macro Aug 30, 2024
@ohmayr
ohmayr merged commit 1967aa1 into main Aug 30, 2024
@ohmayr
ohmayr deleted the refactor-wrap-method-macro branch August 30, 2024 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@parthea parthea parthea approved these changes
@vchudnov-g vchudnov-g vchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@parthea parthea

@vchudnov-g vchudnov-g

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr @parthea @vchudnov-g