Visitar URL original

feat: Adds an X509 certificate provider in the auth libraries. by aeitzman · Pull Request #1624 · googleapis/google-auth-library-java · GitHub

This repository was archived by the owner on May 12, 2026. It is now read-only.

Repository navigation

feat: Adds an X509 certificate provider in the auth libraries. - #1624

Merged

aeitzman merged 12 commits into

googleapis:x509from

aeitzman:x509-java

Mar 20, 2025

Merged

feat: Adds an X509 certificate provider in the auth libraries.#1624
aeitzman merged 12 commits into
googleapis:x509from
aeitzman:x509-java

aeitzman commented Jan 22, 2025 •

edited

Loading

Contributor

This PR creates a new "X509" certificate provider in a new Mtls package to handle workload X509 certificate reading. This is part of a larger feature described in go/x509-workload-auth-library-design

Merging this into a feature branch for now until the entire feature is ready.


          Adds an X509 certificate provider in the auth libraries.

bc27d41

product-auto-label Bot added the size: l label

aeitzman and others added 2 commits

January 22, 2025 10:41


          temporarily remove test case

111f2f1


          Merge branch 'x509' into x509-java

27c497e

aeitzman marked this pull request as ready for review

January 22, 2025 18:42

aeitzman requested review from a team

January 22, 2025 18:42

aeitzman changed the title ~~Adds an X509 certificate provider in the auth libraries.~~ feat: Adds an X509 certificate provider in the auth libraries.

aeitzman assigned lqiu96 and andyrzhao

aeitzman marked this pull request as draft

January 22, 2025 18:42


          fixing formatting

andyrzhao reviewed

View reviewed changes

andyrzhao left a comment

Contributor

Thanks for working on this!

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

oauth2_http/javatests/com/google/auth/mtls/X509ProviderTest.java Resolved

oauth2_http/java/com/google/auth/mtls/X509Provider.java Outdated

+                  return System.getProperty(property, def);
+                }
+                File getWellKnownCertificateConfigFile() {

andyrzhao Jan 28, 2025

Contributor

I think all these helper methods should be "private" whenever possible right? and use protected for those that needs to be overridden by the test mock?

aeitzman Jan 30, 2025

Contributor Author

I'll make this function private, for the methods that need to be overridden, I think its better to keep them package private instead of protected, since we wouldn't expect packages that ingest this library to override them. For context, this is the same pattern that we use for the Default credentials provider in this library (https://github.com/googleapis/google-auth-library-java/blob/main/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java)

aeitzman added 2 commits

January 30, 2025 10:50


          Responding to comments and updating tests

74aaca6


          lint fix

c544c88

andyrzhao requested a review from lqiu96

February 24, 2025 23:08

lqiu96 unassigned lqiu96 and andyrzhao

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved


          Update oauth2_http/java/com/google/auth/mtls/X509Provider.java

c54fedb

Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>


          responding to review comments

889015c

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Outdated

Comment on lines +69 to +71

+                  if (certConfigStream == null){
+                    throw new IllegalArgumentException("certConfigStream must not be null.");
+                  }

lqiu96 Mar 10, 2025 •

edited

Loading

Member

nit: checkNotNull: https://www.javadoc.io/doc/com.google.guava/guava/33.0.0-jre/com/google/common/base/Preconditions.html for the method input argument

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/javatests/com/google/auth/mtls/WorkloadCertificateConfigurationTest.java Resolved

lqiu96 approved these changes

View reviewed changes

lqiu96 left a comment

Member

Changes generally LGTM. Added a few nits and things about comments to warn uses about these classes (intended to be internal).

aeitzman added 2 commits

March 19, 2025 11:57


          formatting and changing the tests to use assertThrows

b46d2a1


          Responding to PR comments and adding a new exception type.

b7903d0

aeitzman marked this pull request as ready for review

March 19, 2025 21:21

andyrzhao reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/X509Provider.java Resolved


          removed catch block

008425d

andyrzhao approved these changes

View reviewed changes

andyrzhao left a comment

Contributor

Thanks for working on this PR! LGTM!

lqiu96 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/mtls/WorkloadCertificateConfiguration.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/javatests/com/google/auth/mtls/X509ProviderTest.java Resolved

lqiu96 reviewed

View reviewed changes

oauth2_http/javatests/com/google/auth/mtls/X509ProviderTest.java Resolved


          Add comment and fix test asserts

2a21fe4

aeitzman merged commit 01ca4be into googleapis:x509

andyrzhao mentioned this pull request

feat: Implement X509 certificate provider #1722

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels