Visitar URL original
feat(bigtable): enable directpath probe and cloudpath fallback with diagnostics by scotthart · Pull Request #16388 · googleapis/google-cloud-cpp · GitHub
Skip to content

feat(bigtable): enable directpath probe and cloudpath fallback with diagnostics - #16388

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:bigtable_dp_cp_fallback
Aug 27, 2026
Merged

feat(bigtable): enable directpath probe and cloudpath fallback with diagnostics#16388
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:bigtable_dp_cp_fallback

Conversation

@scotthart

@scotthart scotthart commented Aug 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner August 26, 2026 21:30
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 26, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces concurrent creation of StubManagers for both DirectPath and CloudPath, along with DirectPath probing, fallback, and diagnostics. It also adds integration tests to verify DirectAccess compatibility metrics. However, the reviewer identified a critical deadlock risk in data_connection.cc where calling f.get() inside a task scheduled on the completion queue (CQ) blocks the CQ thread; using .then() is recommended to safely consume the futures asynchronously.

Comment thread google/cloud/bigtable/data_connection.cc Outdated
Comment thread google/cloud/bigtable/data_connection.cc Outdated
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.27624% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.24%. Comparing base (82fcb08) to head (21e0196).

Files with missing lines Patch % Lines
...d/bigtable/tests/observability_integration_test.cc 7.40% 75 Missing ⚠️
google/cloud/bigtable/data_connection.cc 81.70% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16388      +/-   ##
==========================================
- Coverage   92.30%   92.24%   -0.06%     
==========================================
  Files        2245     2246       +1     
  Lines      211870   212035     +165     
==========================================
+ Hits       195568   195598      +30     
- Misses      16302    16437     +135

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 17ad4f5 into googleapis:main Aug 27, 2026
66 of 67 checks passed

This branch was previously deployed

1 inactive deployment
false — 21e01969 Deployed Aug 26, 2026 by scotthart via Save PR ref #11412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinmoy colinmoy colinmoy approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scotthart @colinmoy