Visitar URL original
fix(openssl): openssl v4.x X509_get_subject_name usage by scotthart · Pull Request #16516 · googleapis/google-cloud-cpp · GitHub
Skip to content

fix(openssl): openssl v4.x X509_get_subject_name usage - #16516

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_openssl_4
Sep 30, 2026
Merged

fix(openssl): openssl v4.x X509_get_subject_name usage#16516
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_openssl_4

Conversation

@scotthart

@scotthart scotthart commented Sep 30, 2026

Copy link
Copy Markdown
Member

This fixes the reported issue and adds a build to our CI that tests with openssl v4.x for better coverage.

fixes #16510

@scotthart
scotthart requested a review from a team as a code owner September 30, 2026 20:30
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new CI build and Dockerfile for testing the SDK with OpenSSL 4 on Fedora 40, along with minor compatibility adjustments in the codebase. Feedback on the Dockerfile highlights a critical issue where gRPC is built against the system OpenSSL instead of the custom OpenSSL 4.x, risking runtime instability from mixed-version loading. Additionally, minor improvements were suggested to remove redundant dynamic linker configuration and simplify the ldconfig call.

Comment thread ci/cloudbuild/dockerfiles/fedora-openssl-4.Dockerfile
Comment thread ci/cloudbuild/dockerfiles/fedora-openssl-4.Dockerfile Outdated
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.36%. Comparing base (e8d543c) to head (4bf9505).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...internal/openssl/parse_service_account_p12_file.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16516      +/-   ##
==========================================
- Coverage   92.37%   92.36%   -0.02%     
==========================================
  Files        2262     2262              
  Lines      217100   217100              
==========================================
- Hits       200543   200520      -23     
- Misses      16557    16580      +23

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit b67a379 into googleapis:main Sep 30, 2026
70 checks passed
@hiroyuki-sato hiroyuki-sato mentioned this pull request Oct 1, 2026
Closed

This branch was successfully deployed

1 active deployment
false — 4bf95056 Deployed Sep 30, 2026 by scotthart via Save PR ref #12185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinmoy colinmoy colinmoy approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google-cloud-cpp 3.10.0 fails to build with OpenSSL 4.x due to X509_get_subject_name() constness

2 participants

@scotthart @colinmoy