Visitar URL original
fix(bigtable): pass routing headers in configMD to NewSessionClientDirectAccessChecker by sushanb · Pull Request #20899 · googleapis/google-cloud-go · GitHub
Skip to content

fix(bigtable): pass routing headers in configMD to NewSessionClientDirectAccessChecker - #20899

Open
sushanb wants to merge 1 commit into
googleapis:mainfrom
sushanb:fix/bigtable-session-client-and-tablecache
Open

sushanb wants to merge 1 commit into
googleapis:mainfrom
sushanb:fix/bigtable-session-client-and-tablecache

Conversation

@sushanb

@sushanb sushanb commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pass configMD (which includes google-cloud-resource-prefix and x-goog-request-params alongside bigtable-features) instead of bare directAccessMD to NewSessionClientDirectAccessChecker in session.NewClient.
  • Ensures the startup DirectAccess compatibility GetClientConfiguration probe carries the required RLS routing headers, matching ClientConfigurationManager's steady-state polls.
  • Add TestNewClient_DirectAccessProbeSendsRoutingHeaders unit test.

@sushanb
sushanb requested review from a team as code owners November 13, 2026 02:55
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@sushanb
sushanb requested a review from mutianf November 13, 2026 02:55
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Nov 13, 2026
@sushanb sushanb changed the title fix(bigtable): attach routing headers to DirectAccess probe and close session/TableCache lifecycle races fix(bigtable): pass routing headers in configMD to NewSessionClientDirectAccessChecker Nov 13, 2026
@sushanb
sushanb force-pushed the fix/bigtable-session-client-and-tablecache branch from c16ece2 to 3c16a72 Compare November 13, 2026 05:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant