Sandbox::https://github.com/googleapis/google-cloud-java/pull/1189

jean-philippe-martin · 2016-08-23T21:09:24Z

This should resolve issue #1188.

One possible point of discussion is that I have left in the tests I used to reproduce the problem and ensure that it was fixed. These tests are only meaningful when gcloud is NOT configured (the opposite requirement of our integration tests) so I have them disabled here, with the intention that they ease manual testing by un-configuring gcloud and running those tests by hand. It would be great if there were a good way to run these tests automatically.

While I was at it I added a friendly message to the integration tests in case someone tries to run them before configuring gcloud.

Sign in to view

+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;


coveralls · 2016-08-24T00:30:34Z

Coverage increased (+0.006%) to 85.877% when pulling 189cd05 on jean-philippe-martin:nio_coexist into f9bbbd4 on GoogleCloudPlatform:master.

coveralls · 2016-08-24T00:35:18Z

Coverage increased (+0.006%) to 85.877% when pulling 189cd05 on jean-philippe-martin:nio_coexist into f9bbbd4 on GoogleCloudPlatform:master.

Sign in to view

  @VisibleForTesting
  public static void setGCloudOptions(StorageOptions newStorageOptions) {
-    storageOptions = newStorageOptions;
+    futureStorageOptions = newStorageOptions;


Sign in to view

+  @Before
+  public void before() {
+    mockOptions = mock(StorageOptions.class);
+    when(mockOptions.service()).thenReturn(StorageOptions.defaultInstance().service());


Sign in to view

-    return MoreObjects.toStringHelper(this).add("storage", storage).toString();
+    return "CloudStorageFileSystemProvider";
+    //initStorage();
+    //return MoreObjects.toStringHelper(this).add("storage", storage).toString();


coveralls · 2016-08-24T22:15:05Z

Coverage increased (+0.006%) to 85.877% when pulling 356da96 on jean-philippe-martin:nio_coexist into f9bbbd4 on GoogleCloudPlatform:master.

Sign in to view

  @Before
  public void before() {
-    CloudStorageFileSystemProvider.setGCloudOptions(LocalStorageHelper.options());
+    CloudStorageFileSystemProvider.setStorageOptions(LocalStorageHelper.options());


coveralls · 2016-08-25T02:48:01Z

Coverage increased (+0.001%) to 85.872% when pulling 32e779b on jean-philippe-martin:nio_coexist into f9bbbd4 on GoogleCloudPlatform:master.

coveralls · 2016-08-25T03:03:04Z

Coverage increased (+0.001%) to 85.872% when pulling 32e779b on jean-philippe-martin:nio_coexist into f9bbbd4 on GoogleCloudPlatform:master.

mziccard · 2016-08-25T13:34:31Z

Thanks @jean-philippe-martin great work!

jean-philippe-martin · 2016-08-25T16:40:27Z

Thank you @mziccard for the good and prompt review!

🤖 I have created a release *beep* *boop* --- ## [2.3.3](googleapis/java-automl@v2.3.2...v2.3.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1195](googleapis/java-automl#1195)) ([e676c4c](googleapis/java-automl@e676c4c)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1203](googleapis/java-automl#1203)) ([b6d75e2](googleapis/java-automl@b6d75e2)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1205](googleapis/java-automl#1205)) ([18ee6b6](googleapis/java-automl@18ee6b6)) * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#1189](googleapis/java-automl#1189)) ([90f3232](googleapis/java-automl@90f3232)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#1190](googleapis/java-automl#1190)) ([77b2a7d](googleapis/java-automl@77b2a7d)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#1191](googleapis/java-automl#1191)) ([f6f08ba](googleapis/java-automl@f6f08ba)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1197](googleapis/java-automl#1197)) ([9c1ff45](googleapis/java-automl@9c1ff45)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1199](googleapis/java-automl#1199)) ([7bd891b](googleapis/java-automl@7bd891b)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#1201](googleapis/java-automl#1201)) ([026ae49](googleapis/java-automl@026ae49)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1192](googleapis/java-automl#1192)) ([94c1c3c](googleapis/java-automl@94c1c3c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#1198](googleapis/java-automl#1198)) ([1be2ead](googleapis/java-automl@1be2ead)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1196](googleapis/java-automl#1196)) ([73871d6](googleapis/java-automl@73871d6)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1200](googleapis/java-automl#1200)) ([ea4490e](googleapis/java-automl@ea4490e)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1202](googleapis/java-automl#1202)) ([3c8f71e](googleapis/java-automl@3c8f71e)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1204](googleapis/java-automl#1204)) ([cc4d715](googleapis/java-automl@cc4d715)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…onfig to v1.5.6 (#1189)

…to v0.9.13 (#1189) * deps: update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Support enumeration of filesytems before configuring gcloud

4711cd5

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016

jean-philippe-martin assigned mziccard Aug 23, 2016

jean-philippe-martin mentioned this pull request Aug 23, 2016

Allow CloudStorageFileSystemProvider without credentials #1188

Closed

Remove unused imports, before->beforeClass

189cd05

jean-philippe-martin reviewed Aug 23, 2016
View reviewed changes

mziccard reviewed Aug 24, 2016
View reviewed changes

jean-philippe-martin added 2 commits August 24, 2016 10:15

Change test to use mocks

3ebee20

Revert ITGcsNio.java

44cd268

mziccard reviewed Aug 24, 2016
View reviewed changes

Use mock storage

356da96

mziccard reviewed Aug 24, 2016
View reviewed changes

Revert CloudStorageFileSystemProvider.toString

ed02398

mziccard reviewed Aug 24, 2016
View reviewed changes

Reviewer comments

32e779b

mziccard changed the title ~~Support enumeration of filesytems before configuring gcloud~~ Support enumeration of filesystems when credentials are not available Aug 25, 2016

mziccard merged commit 343f77d into googleapis:master Aug 25, 2016

jean-philippe-martin deleted the nio_coexist branch August 25, 2016 16:35

theacodes unassigned mziccard Sep 28, 2018

suztomo pushed a commit that referenced this pull request Mar 30, 2026

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

06314ea

…onfig to v1.5.6 (#1189)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

06e0eef

…onfig to v1.5.6 (#1189)

Conversation

jean-philippe-martin commented Aug 23, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Aug 24, 2016

Uh oh!

coveralls commented Aug 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Aug 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Aug 25, 2016

Uh oh!

coveralls commented Aug 25, 2016

Uh oh!

mziccard commented Aug 25, 2016

Uh oh!

jean-philippe-martin commented Aug 25, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants