Visitar URL original
feat(bigquery): add opentelemetry W3C Trace Context to headers by ldetmer · Pull Request #12203 · googleapis/google-cloud-java · GitHub
Skip to content

feat(bigquery): add opentelemetry W3C Trace Context to headers #12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldetmer merged 2 commits into from
Mar 30, 2026
Merged

feat(bigquery): add opentelemetry W3C Trace Context to headers #12203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc647b
feat(bigquery): add opentelemetry W3C Trace Context to headers
ldetmer Mar 25, 2026
d527ded
update to use httpheaders::set command
ldetmer Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...uery/src/main/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.Span;
import io.opentelemetry.api.trace.Tracer;
import io.opentelemetry.api.trace.propagation.W3CTraceContextPropagator;
import io.opentelemetry.context.Context;
import java.io.IOException;

/**
Expand Down Expand Up @@ -77,6 +79,10 @@ public void initialize(HttpRequest request) throws IOException {
// No active span to exists, skip instrumentation
return;
}
// propagate the W3C Trace Context (traceID and spanID) from the active span in headers
W3CTraceContextPropagator.getInstance()

@lqiu96 lqiu96 Mar 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this is to ensure that the parent span's traceID and SpanID values are injected into the current span?

Or is this doing something different?

@ldetmer ldetmer Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is just adding the traceID/spanID into a standard opentelemetry header for tracking purposes. See requirement here. Using the library ensures it pulls the current span from context and creates it following the W3C standard for header label/format.

@ldetmer ldetmer Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Wes took a look and approved this implementation from a metric gathering standpoint

.inject(Context.current(), request.getHeaders(), HttpHeaders::set);

addInitialHttpAttributesToSpan(span, request);

HttpResponseInterceptor originalInterceptor = request.getResponseInterceptor();
Expand Down
17 changes: 17 additions & 0 deletions .../src/test/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,23 @@ public void testNoSpanIsCreatedIfNoActiveSpan() throws IOException {
verify(delegateInitializer, times(1)).initialize(any(HttpRequest.class));
}

@Test
public void testTraceContextIsPropagatedInHeaders() throws IOException {
HttpTransport transport = createTransport();
HttpRequest request = buildGetRequest(transport, initializer, BASE_URL);

HttpResponse response = request.execute();
response.disconnect();

assertEquals(
String.format(
"00-%s-%s-%s",
parentSpan.getSpanContext().getTraceId(),
parentSpan.getSpanContext().getSpanId(),
parentSpan.getSpanContext().getTraceFlags().asHex()),
request.getHeaders().get("traceparent"));
}

@Test
public void testDelegateInitializerIsCalled() throws IOException {
HttpRequestInitializer delegateInitializer = mock(HttpRequestInitializer.class);
Expand Down
Loading