Sandbox::https://github.com/googleapis/google-cloud-java/pull/1224

mziccard · 2016-09-02T15:21:37Z

This PR does the following:

Remove resourcemanager's Policy class
Rename core's IamPolicy to Policy
Add Role class to hold string values for roles
Add Policy.Marshaller and Policy.DefaultMarshaller classes to convert Policy to/from gRPC protos
Add PolicyMarshaller to resourcemanager to convert Policy to/from resourcemanager's protos
Update READMEs, javadoc and examples

@aozarov @ajkannan do you mind having a look? Also, should we add an iam package?

- Remove resourcemanager's Policy class - Rename core's IamPolicy to Policy - Add Role class to hold string values for roles - Add Policy.Marshaller and Policy.DefaultMarshaller classes to convert Policy to/from gRPC protos - Add PolicyMarshaller to resourcemanager to convert Policy to/from resourcemanager's protos - Update READMEs, javadoc and examples

Sign in to view

@@ -37,69 +44,127 @@
 * a set of identities to a role, where the identities can be user accounts, Google groups, Google


aozarov · 2016-09-02T16:04:32Z

Looks good (only skimmed the tests though). Few comments/suggestions.

I am not convinced that we should put the Policy under iam sub-package unless we expect to have more kinds of policies in the future but fine either way.

coveralls · 2016-09-02T16:09:48Z

Coverage increased (+0.004%) to 85.207% when pulling 1431f0d on mziccard:refactor-iam into 7309be5 on GoogleCloudPlatform:master.

ajkannan · 2016-09-02T16:46:23Z

LGTM

coveralls · 2016-09-05T14:31:01Z

Coverage increased (+0.01%) to 85.209% when pulling 462910e on mziccard:refactor-iam into 3ea98b1 on GoogleCloudPlatform:master.

mziccard · 2016-09-05T15:01:38Z

Comments fixed, PTAL

I am not convinced that we should put the Policy under iam sub-package unless we expect to have more kinds of policies in the future but fine either way.

I was considering to put: Policy, Role and Identity under the iam package but I am not convinced either.

aozarov · 2016-09-06T16:04:49Z

LGTM (one comment was not addressed, your call).

mziccard · 2016-09-06T16:07:56Z

@aozarov Another thing we might want to discuss is wether to store etag as byte[] or String. gRPC stores it as a ByteString (immutable byte array), we currently store it as String, do you have any preferences?

aozarov · 2016-09-06T16:10:53Z

My preference would be that as long as we wrap (and not expose) the underlying protobuf we should return it as String (which is also what we did for the api-client based Services).

coveralls · 2016-09-06T20:02:57Z

Coverage increased (+0.01%) to 85.209% when pulling c046d6e on mziccard:refactor-iam into 3ea98b1 on GoogleCloudPlatform:master.

…#1224) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](googleapis/java-automl@v2.3.5...v2.3.6) (2022-08-25) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1224](googleapis/java-automl#1224)) ([731ed9f](googleapis/java-automl@731ed9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* test: expose test-jar and mock classes in oauth2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: adapt appengine oauth2-http import * test: correct appengine import in pom * test: correct base serialization test export * chore: expose MockTokenServerTransportFactory * chore: infer version from parent in appengine pom dependencies --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: support untyped NULL value parameters * test: add tests for untyped null parameter values * fix: update metadata test with the new table * test: add expected table for PG * refactor: move logic to ParameterStore

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

mziccard added api: core api: cloudresourcemanager Issues related to the Resource Manager API. labels Sep 2, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016

aozarov reviewed Sep 2, 2016
View reviewed changes

Add factory methods for primitive roles, other minor fixes

462910e

mziccard force-pushed the refactor-iam branch from b3c94f6 to 462910e Compare September 5, 2016 14:15

Put IAM roles within quotes in javadoc

c046d6e

aozarov merged commit a493457 into googleapis:master Sep 6, 2016

This was referenced Aug 25, 2022

chore: release monorepo_script_output #8199

Closed

chore: release main #8222

Closed

release-please Bot mentioned this pull request Sep 23, 2022

chore: release main #8444

Closed

release-please Bot mentioned this pull request Oct 3, 2022

chore(new-main): release 0.1.0 #8510

Closed

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore: update graalvm container images to 22.3.3 (#1224)

246d025

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore(main): release 0.127.0 (#1224)

c48670b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore(main): release 0.127.0 (#1224)

a65dd1e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026

chore(main): release 2.6.3-SNAPSHOT (googleapis#1224)

c56ab5d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Navigation Menu

Repository navigation

Refactor IAM-related classes to be ready to support more services - #1224

Refactor IAM-related classes to be ready to support more services#1224
aozarov merged 3 commits into
googleapis:masterfrom
mziccard:refactor-iam

mziccard commented Sep 2, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Sep 2, 2016

Uh oh!

coveralls commented Sep 2, 2016

Uh oh!

ajkannan commented Sep 2, 2016

Uh oh!

coveralls commented Sep 5, 2016

Uh oh!

mziccard commented Sep 5, 2016

Uh oh!

aozarov commented Sep 6, 2016

Uh oh!

mziccard commented Sep 6, 2016

Uh oh!

aozarov commented Sep 6, 2016

Uh oh!

coveralls commented Sep 6, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -37,69 +44,127 @@
		* a set of identities to a role, where the identities can be user accounts, Google groups, Google

Conversation

mziccard commented Sep 2, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Sep 2, 2016

Uh oh!

coveralls commented Sep 2, 2016

Uh oh!

ajkannan commented Sep 2, 2016

Uh oh!

coveralls commented Sep 5, 2016

Uh oh!

mziccard commented Sep 5, 2016

Uh oh!

aozarov commented Sep 6, 2016

Uh oh!

mziccard commented Sep 6, 2016

Uh oh!

aozarov commented Sep 6, 2016

Uh oh!

coveralls commented Sep 6, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants