Sandbox::https://github.com/googleapis/google-cloud-java/pull/1393

mziccard · 2016-11-11T20:35:01Z

No description provided.

mziccard · 2016-11-11T20:46:52Z

@garrettjonesgoogle care to have a look?

coveralls · 2016-11-11T21:34:00Z

Coverage decreased (-0.07%) to 84.185% when pulling e8e68f2 on mziccard:translate into 8ec721e on GoogleCloudPlatform:master.

garrettjonesgoogle

LGTM - this all looks reasonable to me. Just one casing issue.

Sign in to view

  }

  static Translation fromPb(TranslationsResource translationPb) {
+    // todo remove get("model") as soon as REST apiary supports model


coveralls · 2016-11-12T01:04:31Z

Coverage decreased (-0.07%) to 84.185% when pulling 655b8ab on mziccard:translate into 8ec721e on GoogleCloudPlatform:master.

mziccard · 2016-11-14T17:54:39Z

@garrettjonesgoogle as requested by the translate team I switched back to GET for TranslateText. A bug in the POST version prevents the API from failing when model is used for non-whitelisted projects. Can you have a look?

Sign in to view

-              .execute()
-              .getTranslations();
+      // TODO use POST as soon as usage of "model" causes error in non-whitelisted projects
+       String targetLanguage =


garrettjonesgoogle · 2016-11-14T18:14:52Z

LGTM after the indentation, TODO wording, and unused imports are addressed

coveralls · 2016-11-14T18:24:51Z

Coverage decreased (-0.03%) to 84.222% when pulling de8c21d on mziccard:translate into 8ec721e on GoogleCloudPlatform:master.

coveralls · 2016-11-14T19:49:27Z

Coverage decreased (-0.03%) to 84.217% when pulling 6e7de7f on mziccard:translate into 8ec721e on GoogleCloudPlatform:master.

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat: add a new searchable field kmsKeys fix: deprecate searchable field kmsKey PiperOrigin-RevId: 479103182 Source-Link: googleapis/googleapis@7b5a467 Source-Link: https://github.com/googleapis/googleapis-gen/commit/417aefa0fb633d0f171a607779e9f0e19c8b8b7f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDE3YWVmYTBmYjYzM2QwZjE3MWE2MDc3NzllOWYwZTE5YzhiOGI3ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>

…0.5 (#1393)

🤖 I have created a release *beep* *boop* --- ## [2.19.1](https://togithub.com/googleapis/java-datastore/compare/v2.19.0...v2.19.1) (2024-04-19) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#1403](https://togithub.com/googleapis/java-datastore/issues/1403)) ([d23dc4c](https://togithub.com/googleapis/java-datastore/commit/d23dc4c26a95f2c323ade4db9a88d5435a173be8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…gin to v3.4.1 (#1393) Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

…gin to v3.4.1 (#1393) Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

…v6.51.0 (googleapis#1393)

🤖 I have created a release *beep* *boop* --- ## [2.14.1](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.14.0...v2.14.1) (2023-10-14) ### Dependencies * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.51.0 ([googleapis#1393](https://togithub.com/googleapis/java-spanner-jdbc/issues/1393)) ([fd8b406](https://togithub.com/googleapis/java-spanner-jdbc/commit/fd8b40629d04d9b9fd587d843f36233005213ef9)) * Update dependency org.springframework.data:spring-data-bom to v2023.0.5 ([googleapis#1391](https://togithub.com/googleapis/java-spanner-jdbc/issues/1391)) ([e3a07b9](https://togithub.com/googleapis/java-spanner-jdbc/commit/e3a07b9543e5b2ca1ee1f99ab9b3cd0fb68822ad)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…plugin to v3.1.2 (#1393)

🤖 I have created a release *beep* *boop* --- ## [2.12.0](googleapis/java-bigtable@v2.11.2...v2.12.0) (2022-09-15) ### Features * **generated:** Publish CBT deletion_protection field in Table, UpdateTableRequest, and UpdateTable API ([33d3b7c](googleapis/java-bigtable@33d3b7c)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.4.3 ([googleapis#1386](googleapis/java-bigtable#1386)) ([516ae2e](googleapis/java-bigtable@516ae2e)) * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.4.3 ([googleapis#1387](googleapis/java-bigtable#1387)) ([c68b54b](googleapis/java-bigtable@c68b54b)) * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.4.4 ([googleapis#1395](googleapis/java-bigtable#1395)) ([6eb5654](googleapis/java-bigtable@6eb5654)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([googleapis#1384](googleapis/java-bigtable#1384)) ([7b10755](googleapis/java-bigtable@7b10755)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([googleapis#1393](googleapis/java-bigtable#1393)) ([2a963fe](googleapis/java-bigtable@2a963fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Update translate endpoint, use POST and support credentials

b6dc7e9

mziccard added the api: translation Issues related to the Cloud Translation API API. label Nov 11, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2016

Add support for the model option

e8e68f2

mziccard force-pushed the translate branch from a596225 to e8e68f2 Compare November 11, 2016 20:41

garrettjonesgoogle reviewed Nov 11, 2016

View reviewed changes

Comment thread google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java Outdated

}

static Translation fromPb(TranslationsResource translationPb) {

// todo remove get("model") as soon as REST apiary supports model

This comment was marked as spam.

Sign in to view

Make TODO uppercase

655b8ab

mziccard added 2 commits November 14, 2016 14:45

Add integration test for Translate's model

adeda0f

Switch back to GET for translate and update docs

de8c21d

garrettjonesgoogle reviewed Nov 14, 2016

View reviewed changes

Fix indentation and remove unused import

6e7de7f

mziccard mentioned this pull request Nov 14, 2016

Release 0.6.0 #1398

Merged

mziccard merged commit 6027026 into googleapis:master Nov 14, 2016

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

deps: update dependency com.google.cloud:google-cloud-logging to v3.2…

cfdb3ce

…0.5 (#1393)

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

chore(deps): update dependency org.apache.maven.plugins:maven-jar-plu…

4313f6c

…gin to v3.4.1 (#1393) Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

chore(deps): update dependency org.apache.maven.plugins:maven-jar-plu…

12d6068

…gin to v3.4.1 (#1393) Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

deps: update dependency com.google.cloud:google-cloud-spanner-bom to …

fd8b406

…v6.51.0 (googleapis#1393)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

build(deps): update dependency org.apache.maven.plugins:maven-deploy-…

c165f89

…plugin to v3.1.2 (#1393)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

build(deps): update dependency org.apache.maven.plugins:maven-deploy-…

53ff7b5

…plugin to v3.1.2 (#1393)

Navigation Menu

Repository navigation

Translate API updates - #1393

Translate API updates#1393
mziccard merged 6 commits into
googleapis:masterfrom
mziccard:translate

mziccard commented Nov 11, 2016

Uh oh!

mziccard commented Nov 11, 2016

Uh oh!

coveralls commented Nov 11, 2016

Uh oh!

garrettjonesgoogle left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 12, 2016

Uh oh!

mziccard commented Nov 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Nov 14, 2016

Uh oh!

coveralls commented Nov 14, 2016

Uh oh!

coveralls commented Nov 14, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mziccard commented Nov 11, 2016

Uh oh!

mziccard commented Nov 11, 2016

Uh oh!

coveralls commented Nov 11, 2016

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 12, 2016

Uh oh!

mziccard commented Nov 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Nov 14, 2016

Uh oh!

coveralls commented Nov 14, 2016

Uh oh!

coveralls commented Nov 14, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants