Visitar URL original
pubsub: re-implement periodic deadline adjustment by pongad · Pull Request #2639 · googleapis/google-cloud-java · GitHub
Skip to content

pubsub: re-implement periodic deadline adjustment - #2639

Merged
pongad merged 2 commits into
googleapis:masterfrom
pongad:deadline-adj
Nov 20, 2017
Merged

pubsub: re-implement periodic deadline adjustment#2639
pongad merged 2 commits into
googleapis:masterfrom
pongad:deadline-adj

Conversation

@pongad

@pongad pongad commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

@mdietz94 Do you also want to take a look?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2017
mdietz94
mdietz94 suggested changes Nov 17, 2017
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated
private ScheduledFuture<?> pendingAcksAlarm;
// The deadline should be set before use. Here, set it to something unreasonable,
// so we fail loudly if we mess up.
private final AtomicInteger messageDeadlineSeconds = new AtomicInteger(-1234);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated
sec = Subscriber.MAX_ACK_DEADLINE_SECONDS;
}

messageDeadlineSeconds.set(sec);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
@@ -139,10 +135,6 @@ private Subscriber(Builder builder) {
cachedSubscriptionNameString = subscriptionName.toString();
ackExpirationPadding = builder.ackExpirationPadding;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

Thank you @mdietz94 PTAL

@pongad
pongad merged commit ae1b0e7 into googleapis:master Nov 20, 2017
@pongad
pongad deleted the deadline-adj branch November 20, 2017 00:34
@guess-burger guess-burger mentioned this pull request Jun 28, 2018
Closed
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Thu Sep 12 02:21:21 UTC 2024 (
36d2c99 
#2639)

* chore: Update generation configuration at Thu Sep 12 02:21:21 UTC 2024

* chore: generate libraries at Thu Sep 12 02:21:47 UTC 2024
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@JoeWang1127
feat: add libraries_bom_version to generation configuration (#2639)
76eb62b 
In this PR:
- Add `libraries_bom_version` as a required parameter in generation
config.

The integration test is verified using a feature branch of synthtool:
googleapis/synthtool#1956.

The synthtool commit in integration test is changed to
`63cc541da2c45fcfca2136c43e638da1fbae174d` after the above feature
branch is merged.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.39.0 (#2594)
3ff4744 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.39.0</summary>

##
[2.39.0](googleapis/sdk-platform-java@v2.38.1...v2.39.0)
(2024-04-18)


### Features

* add `libraries_bom_version` to generation configuration
([#2639](googleapis/sdk-platform-java#2639))
([76eb62b](googleapis/sdk-platform-java@76eb62b))
* Add ChannelPoolSettings Getter for gRPC's ChannelProvider
([#2612](googleapis/sdk-platform-java#2612))
([c8dae8f](googleapis/sdk-platform-java@c8dae8f))
* add config change
([#2604](googleapis/sdk-platform-java#2604))
([a8c93b5](googleapis/sdk-platform-java@a8c93b5))
* add entry point
([#2616](googleapis/sdk-platform-java#2616))
([f5492bb](googleapis/sdk-platform-java@f5492bb))
* add generation config comparator
([#2587](googleapis/sdk-platform-java#2587))
([3461166](googleapis/sdk-platform-java@3461166))
* Add JavadocJar Task to build.gradle for self service libraries
([#2593](googleapis/sdk-platform-java#2593))
([a66df18](googleapis/sdk-platform-java@a66df18))
* Client/StubSettings' getEndpoint() returns the resolved endpoint
([#2440](googleapis/sdk-platform-java#2440))
([7cf0d8f](googleapis/sdk-platform-java@7cf0d8f))
* generate selected libraries
([#2598](googleapis/sdk-platform-java#2598))
([e4572d1](googleapis/sdk-platform-java@e4572d1))
* Validate the Universe Domain inside Java-Core
([#2592](googleapis/sdk-platform-java#2592))
([a5e1141](googleapis/sdk-platform-java@a5e1141))


### Bug Fixes

* add main to `generate_repo.py`
([#2607](googleapis/sdk-platform-java#2607))
([df39521](googleapis/sdk-platform-java@df39521))
* correct deep-remove and deep-preserve regexes
([#2572](googleapis/sdk-platform-java#2572))
([7d59fa1](googleapis/sdk-platform-java@7d59fa1))
* first attempt should use the min of RPC timeout and total timeout
([#2641](googleapis/sdk-platform-java#2641))
([806a52e](googleapis/sdk-platform-java@806a52e))
* remove duplicated calls to AutoValue builders
([#2636](googleapis/sdk-platform-java#2636))
([c883b8f](googleapis/sdk-platform-java@c883b8f))
* remove unnecessary slf4j and AbstractGoogleClientRequest native image
configs
([9cb7c09](googleapis/sdk-platform-java@9cb7c09))
* remove unnecessary slf4j and AbstractGoogleClientRequest native image
configs
([#2628](googleapis/sdk-platform-java#2628))
([9cb7c09](googleapis/sdk-platform-java@9cb7c09))


### Dependencies

* update arrow.version to v15.0.2
([#2589](googleapis/sdk-platform-java#2589))
([0947407](googleapis/sdk-platform-java@0947407))
* update dependency
com.google.cloud.opentelemetry:detector-resources-support to v0.28.0
([#2649](googleapis/sdk-platform-java#2649))
([079bcff](googleapis/sdk-platform-java@079bcff))
* update dependency gitpython to v3.1.41 [security]
([#2625](googleapis/sdk-platform-java#2625))
([018e9a9](googleapis/sdk-platform-java@018e9a9))
* update dependency net.bytebuddy:byte-buddy to v1.14.13
([#2646](googleapis/sdk-platform-java#2646))
([5a79cd2](googleapis/sdk-platform-java@5a79cd2))
* update dependency org.threeten:threeten-extra to v1.8.0
([#2650](googleapis/sdk-platform-java#2650))
([5666adb](googleapis/sdk-platform-java@5666adb))
* update dependency org.threeten:threetenbp to v1.6.9
([#2602](googleapis/sdk-platform-java#2602))
([767eec1](googleapis/sdk-platform-java@767eec1))
* update dependency org.threeten:threetenbp to v1.6.9
([#2665](googleapis/sdk-platform-java#2665))
([563d8ae](googleapis/sdk-platform-java@563d8ae))
* update google api dependencies
([#2584](googleapis/sdk-platform-java#2584))
([22733b1](googleapis/sdk-platform-java@22733b1))
* update googleapis/java-cloud-bom digest to 7071341
([#2608](googleapis/sdk-platform-java#2608))
([8f34fe7](googleapis/sdk-platform-java@8f34fe7))
* update netty dependencies to v4.1.109.final
([#2597](googleapis/sdk-platform-java#2597))
([6b6939e](googleapis/sdk-platform-java@6b6939e))
* update opentelemetry-java monorepo to v1.37.0
([#2652](googleapis/sdk-platform-java#2652))
([708cf7f](googleapis/sdk-platform-java@708cf7f))
* update protobuf dependencies to v3.25.3
([#2491](googleapis/sdk-platform-java#2491))
([e2235a8](googleapis/sdk-platform-java@e2235a8))
* update slf4j monorepo to v2.0.13
([#2647](googleapis/sdk-platform-java#2647))
([2e3d813](googleapis/sdk-platform-java@2e3d813))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
afe27d8 
…58.0 (#2639)
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
224fe43 
…58.0 (#2639)
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@release-please @cloud-java-bot
chore(main): release 2.63.0 (googleapis#2639)
c7f6a33 
* chore(main): release 2.63.0

* chore: generate libraries at Wed Jul 30 21:12:44 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle
@jba jba Awaiting requested review from jba
1 more reviewer
@mdietz94 mdietz94 mdietz94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad @mdietz94 @googlebot