Visitar URL original
pubsub: respect total expiration while modacking by pongad · Pull Request #2715 · googleapis/google-cloud-java · GitHub
Skip to content

pubsub: respect total expiration while modacking - #2715

Merged
pongad merged 3 commits into
googleapis:masterfrom
pongad:pubsub-max-modack
Jan 4, 2018
Merged

pubsub: respect total expiration while modacking#2715
pongad merged 3 commits into
googleapis:masterfrom
pongad:pubsub-max-modack

Conversation

@pongad

@pongad pongad commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

Previously we use total expiration only to decide whether to send
new modacks. If we send modacks close to the expiration, we might
extend the lease beyond the total expiration time.

This commit shortens the lease when we approach the expiration time
so we never go over.

@mdietz94

@pongad
pubsub: respect total expiration while modacking
9070452 
Previously we use total expiration only to decide whether to send
new modacks. If we send modacks close to the expiration, we might
extend the lease beyond the total expiration time.

This commit shortens the lease when we approach the expiration time
so we never go over.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2017
mdietz94
mdietz94 suggested changes Dec 19, 2017
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated
}
it.remove();
if (totalExpiration.isAfter(now)) {
expiringModack.put(now.until(totalExpiration, ChronoUnit.SECONDS), ackId);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated
PendingModifyAckDeadline modack = new PendingModifyAckDeadline(getMessageDeadlineSeconds());
int extendSeconds = getMessageDeadlineSeconds();
PendingModifyAckDeadline modack = new PendingModifyAckDeadline(extendSeconds);
ArrayListMultimap<Long, String> expiringModack = ArrayListMultimap.create();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Dec 19, 2017

Copy link
Copy Markdown
Contributor Author

@mdietz94 PTAL

@pongad

pongad commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

@mdietz94 Ping

@mdietz94

mdietz94 commented Jan 4, 2018

Copy link
Copy Markdown

Sorry this got lost in my inbox while I was OOO

@pongad

pongad commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

No problem!

@pongad
pongad merged commit f6ed7fc into googleapis:master Jan 4, 2018
@pongad
pongad deleted the pubsub-max-modack branch January 4, 2018 07:30
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
7f13f8f 
…49.0 (#2715)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@lqiu96
fix: Return resolved endpoint from StubSettings' Builder (#2715)
6139a73
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.40.0 (#2679)
32ebbe1 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](googleapis/sdk-platform-java@v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](googleapis/sdk-platform-java#2699))
([90a28ef](googleapis/sdk-platform-java@90a28ef))
* add a CLI tool to validate generation configuration
([#2691](googleapis/sdk-platform-java#2691))
([f52f8cc](googleapis/sdk-platform-java@f52f8cc))
* Parser to consume the api-versioning value from proto
([#2630](googleapis/sdk-platform-java#2630))
([c112b37](googleapis/sdk-platform-java@c112b37))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](googleapis/sdk-platform-java#2671))
([cb5ada0](googleapis/sdk-platform-java@cb5ada0))


### Bug Fixes

* change folder prefix for adding headers
([#2688](googleapis/sdk-platform-java#2688))
([ab5ba1d](googleapis/sdk-platform-java@ab5ba1d))
* Log HttpJson's async thread pool core size
([#2697](googleapis/sdk-platform-java#2697))
([31038d1](googleapis/sdk-platform-java@31038d1))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](googleapis/sdk-platform-java#2637))
([fd12e0f](googleapis/sdk-platform-java@fd12e0f))
* Return resolved endpoint from StubSettings' Builder
([#2715](googleapis/sdk-platform-java#2715))
([6139a73](googleapis/sdk-platform-java@6139a73))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](googleapis/sdk-platform-java#2681))
([2239c8c](googleapis/sdk-platform-java@2239c8c))
* update dependency absl-py to v2.1.0
([#2659](googleapis/sdk-platform-java#2659))
([b2b7738](googleapis/sdk-platform-java@b2b7738))
* update dependency gitpython to v3.1.43
([#2656](googleapis/sdk-platform-java#2656))
([6d273ad](googleapis/sdk-platform-java@6d273ad))
* update dependency lxml to v5.2.1
([#2661](googleapis/sdk-platform-java#2661))
([7a34168](googleapis/sdk-platform-java@7a34168))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](googleapis/sdk-platform-java#2703))
([72b0441](googleapis/sdk-platform-java@72b0441))
* update dependency typing to v3.10.0.0
([#2663](googleapis/sdk-platform-java#2663))
([4c64e98](googleapis/sdk-platform-java@4c64e98))
* update gapic-showcase to v0.33.0
([#2653](googleapis/sdk-platform-java#2653))
([5c12155](googleapis/sdk-platform-java@5c12155))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](googleapis/sdk-platform-java#2682))
([82f5ce8](googleapis/sdk-platform-java@82f5ce8))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@BenWhitehead
fix: update GrpcStorageOptions to attempt direct path by default (#2715)
d394ecc 
Update our tests to not attempt direct path, as we do not always run in gce.
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@release-please @cloud-java-bot
chore(main): release 2.70.1-SNAPSHOT (googleapis#2715)
26d315c 
* chore(main): release 2.70.1-SNAPSHOT

* chore: generate libraries at Fri Dec 12 14:04:07 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle
1 more reviewer
@mdietz94 mdietz94 mdietz94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad @mdietz94 @googlebot