Visitar URL original
Bigtable: limit mutation sizes in the client to avoid overloading the server by igorbernstein2 · Pull Request #3695 · googleapis/google-cloud-java · GitHub
Skip to content

Bigtable: limit mutation sizes in the client to avoid overloading the server - #3695

Merged
pongad merged 2 commits into
googleapis:masterfrom
igorbernstein2:request-limit
Sep 18, 2018
Merged

Bigtable: limit mutation sizes in the client to avoid overloading the server#3695
pongad merged 2 commits into
googleapis:masterfrom
igorbernstein2:request-limit

Conversation

@igorbernstein2

@igorbernstein2 igorbernstein2 commented Sep 18, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2018
@igorbernstein2

igorbernstein2 commented Sep 18, 2018

Copy link
Copy Markdown
Contributor Author

@kevinsi4508, can you take a look when you have a moment?

sduskis
sduskis reviewed Sep 18, 2018
View reviewed changes
Comment thread ...s/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
"Byte size of mutations is too large");

numMutations++;
byteSize += mutation.getSerializedSize();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

kevinsi4508
kevinsi4508 approved these changes Sep 18, 2018
View reviewed changes

@kevinsi4508 kevinsi4508 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit.

Comment thread ...s/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java Outdated
@InternalApi("Visible for testing")
static final int MAX_MUTATIONS = 100_000;
@InternalApi("Visible for testing")
static final int MAX_MUTATION_SIZE = 200 * 1024 * 1024;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@igorbernstein2

igorbernstein2 commented Sep 18, 2018

Copy link
Copy Markdown
Contributor Author

@pongad this is ready for you when you get a chance

@pongad
pongad merged commit 3fa1fa0 into googleapis:master Sep 18, 2018
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-bigquery…
082d2b2 
…storage-bom to v3.11.4 (#3695)
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-bigquery…
8e59e22 
…storage-bom to v3.11.4 (#3695)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.55.1 (#3695)
e16d457 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.55.1</summary>

##
[2.55.1](googleapis/sdk-platform-java@v2.55.0...v2.55.1)
(2025-03-12)


### Dependencies

* revert "deps: update arrow.version to v18.2.0"
([#3694](googleapis/sdk-platform-java#3694))
([a0b6133](googleapis/sdk-platform-java@a0b6133))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@olavloite
test: unflake ITDmlReturningTest (#3695)
8751bb5 
Fixes #3575
Fixes #3342
Fixes #3274
Fixes #3174
Fixes #3169
Fixes #3059
Fixes #3002
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@igorbernstein2 @pongad
Bigtable: limit mutation sizes in the client to avoid overloading the…
8422c1d 
… server (googleapis#3695)

* Bigtable: limit mutation sizes in the client to avoid overloading the server

* address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@sduskis sduskis sduskis left review comments
@kevinsi4508 kevinsi4508 kevinsi4508 approved these changes
@pongad pongad pongad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@igorbernstein2 @sduskis @pongad @kevinsi4508 @googlebot