Sandbox::https://github.com/googleapis/google-cloud-java/pull/807

mziccard · 2016-03-29T16:02:55Z

This is (finally) a first attempt at fixing #456.

Not related to this PR: in dns what was the Option class became AbstractOption and is now abstract. I agree that this class should be abstract but I believed we never used the Abstract prefix for abstract classes. I believe we should stick to Option (or BaseOption if you prefer) and should make all other classes abstract as well. Thoughts?

coveralls · 2016-03-29T16:14:47Z

Coverage decreased (-0.03%) to 85.548% when pulling 712b255 on mziccard:field-selector into 2819942 on GoogleCloudPlatform:master.

Sign in to view

+
+/**
+ * Interface for Google Cloud resource's fields. Implementations of this interface can be used to
+ * select only desired fields when getting or listing Google Cloud resources.


- Add FieldSelector.SelectorHelper with static methods to create selectors - Add SelectorHelperTest - Rename dns.AbstractOption to Option, make other Option classes abstract - Add OptionTest class to resource manager and refactor other OptionTest classes

coveralls · 2016-03-30T14:07:37Z

Coverage decreased (-0.08%) to 85.496% when pulling 1710a4c on mziccard:field-selector into 6747274 on GoogleCloudPlatform:master.

mziccard · 2016-03-30T14:11:22Z

I fixed comments:

Add FieldSelector.SelectorHelper with static methods to create selectors
Add SelectorHelperTest
Rename dns.AbstractOption to Option, make other Option classes abstract
Add OptionTest class to resource manager and refactor other OptionTest classes

Sign in to view

+     * string selector returned by this method can be used for field selection in API calls that
+     * return a list of resources. This method is not supposed to be used directly by users.
+     */
+    public static String selector(String containerName, List<FieldSelector> required,


aozarov · 2016-03-31T01:11:06Z

Looks great. Few comments and suggestions and I think you can merge after.

- Rename selector method for lists to listSelector - Update selectors to accept List<? extends FieldSelector> parameters - Add missing unit test for listSelector - Remove redundant extends Serializable from dns' option classes

coveralls · 2016-03-31T11:51:12Z

Coverage decreased (-0.07%) to 85.506% when pulling 8db4b9b on mziccard:field-selector into 6747274 on GoogleCloudPlatform:master.

Sign in to view

  /**
   * Class for specifying zone listing options.
   */
-  class ZoneListOption extends AbstractOption implements Serializable {


…21.2 (googleapis#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.1` -> `3.21.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/compatibility-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/confidence-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.2`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-kms).

🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-kms@v2.5.3...v2.6.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#801](googleapis/java-kms#801)) ([783d389](googleapis/java-kms@783d389)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#809](googleapis/java-kms#809)) ([b9afbae](googleapis/java-kms@b9afbae)) ### Dependencies * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([googleapis#807](googleapis/java-kms#807)) ([e043035](googleapis/java-kms@e043035)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

…plugin to v3 (#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-secretmanager).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…der to v2.5.3 (#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-recommender](https://togithub.com/googleapis/java-recommender) | `2.5.2` -> `2.5.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.3/compatibility-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.3/confidence-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.3 (googleapis#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iot).

#807) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 485623855 Source-Link: https://togithub.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9

…1.4 (#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billingbudgets).

🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18) ### Features * **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a)) * next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212)) ### Bug Fixes * remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09)) * update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db)) * update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d)) * update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db)) * update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c)) * update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567)) * update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17)) * update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1)) * update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41)) * update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507)) * update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…plugin to v3 (#807) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging-logback).

…e to v2.10.1 (#807) * chore(deps): update dependency com.google.cloud:google-cloud-datastore to v2.10.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…jdbc to v2.6.4 (googleapis#807) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner-jdbc](https://togithub.com/googleapis/java-spanner-jdbc) | `2.6.3` -> `2.6.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.6.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.6.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.6.4/compatibility-slim/2.6.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.6.4/confidence-slim/2.6.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-spanner-jdbc</summary> ### [`v2.6.4`](https://togithub.com/googleapis/java-spanner-jdbc/blob/HEAD/CHANGELOG.md#264-httpsgithubcomgoogleapisjava-spanner-jdbccomparev263v264-2022-04-21) [Compare Source](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.6.3...v2.6.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).

🤖 I have created a release *beep* *boop* --- ### [0.123.20](googleapis/java-storage-nio@v0.123.19...v0.123.20) (2022-02-08) ### Dependencies * update dependency com.google.cloud:google-cloud-storage to v2.4.0 ([#806](googleapis/java-storage-nio#806)) ([9ec90a4](googleapis/java-storage-nio@9ec90a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.114.1](https://www.github.com/googleapis/java-pubsub/compare/v1.114.0...v1.114.1) (2021-08-23) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.0 ([#806](https://www.github.com/googleapis/java-pubsub/issues/806)) ([744eacd](https://www.github.com/googleapis/java-pubsub/commit/744eacd007c9de224790b75eb5c060acaf6245ec)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.1.0 ([#807](https://www.github.com/googleapis/java-pubsub/issues/807)) ([e88ff93](https://www.github.com/googleapis/java-pubsub/commit/e88ff93b0fc476f27221d9e5e4c81811a26815ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.114.1](https://www.github.com/googleapis/java-pubsub/compare/v1.114.0...v1.114.1) (2021-08-23) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.0 ([#806](https://www.github.com/googleapis/java-pubsub/issues/806)) ([db6d5d8](https://www.github.com/googleapis/java-pubsub/commit/db6d5d87274d001f9d23c307560f3f444c0c2ad3)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.1.0 ([#807](https://www.github.com/googleapis/java-pubsub/issues/807)) ([f026aed](https://www.github.com/googleapis/java-pubsub/commit/f026aed9c73821761080880cb4c7f992e0a5e225)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Add common interface for field selectors

712b255

mziccard added the type: cleanup An internal cleanup or hygiene concern. label Mar 29, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2016

aozarov reviewed Mar 29, 2016
View reviewed changes

mziccard force-pushed the field-selector branch from d9df447 to 1710a4c Compare March 30, 2016 13:59

mziccard reviewed Mar 30, 2016
View reviewed changes

Minor refactoring for SelectorHelper

8db4b9b

- Rename selector method for lists to listSelector - Update selectors to accept List<? extends FieldSelector> parameters - Add missing unit test for listSelector - Remove redundant extends Serializable from dns' option classes

mziccard reviewed Mar 31, 2016
View reviewed changes

Comment thread gcloud-java-dns/src/main/java/com/google/gcloud/dns/Dns.java

/**

* Class for specifying zone listing options.

*/

class ZoneListOption extends AbstractOption implements Serializable {

This comment was marked as spam.

Sign in to view

mziccard merged commit 4b1a4fd into googleapis:master Mar 31, 2016

mziccard mentioned this pull request Mar 31, 2016

Add a common interface for resource field enums #456

Closed

suztomo added a commit that referenced this pull request Feb 1, 2023

feat: next release from main branch is 2.7.0 (#807)

2145212

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

fix(java): add -ntp flag to native image testing command (#1299) (#807)

aa6654a

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

fix(java): add -ntp flag to native image testing command (#1299) (#807)

4be0d5a

Navigation Menu

Repository navigation

Add common interface for field selectors - #807

Add common interface for field selectors#807
mziccard merged 3 commits into
googleapis:masterfrom
mziccard:field-selector

mziccard commented Mar 29, 2016

Uh oh!

coveralls commented Mar 29, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 30, 2016

Uh oh!

mziccard commented Mar 30, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 31, 2016

Uh oh!

coveralls commented Mar 31, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mziccard commented Mar 29, 2016

Uh oh!

coveralls commented Mar 29, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 30, 2016

Uh oh!

mziccard commented Mar 30, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 31, 2016

Uh oh!

coveralls commented Mar 31, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants