Sandbox::https://github.com/googleapis/google-cloud-python/pull/1014

tseaver · 2015-07-23T15:00:16Z

No description provided.

Sign in to view

@dhermes

Addresses feedback from @dhermes on #1014.

@dhermes

Addresses feedback from @dhermes in #1014.

@dhermes

Addresses feedback from @dhermes in #1014.

Sign in to view

dhermes · 2015-07-23T21:56:44Z

Just two things left

"Should the name not be object_names or object_expression or something more generic?"
It seems the idiom of polling is ubiquitous. We should consider a class or method to aid in this process

tseaver · 2015-07-24T00:34:20Z

"Should the name not be object_names or object_expression or something more generic?"

Per Loading Data into BigQuery, the name is used to fill a URI in the form gs://<bucket>/<object>.

Per https://cloud.google.com/bigquery/docs/reference/v2/jobs#configuration.load, that URE can have the glob character only at the end. That value is populated into a repeatable JSON field, configuration.load.sourceUris. We want to support multiple values, any of which might be globbed.

It seems the idiom of polling is ubiquitous. We should consider a class or method to aid in this process.

Maybe so. There might even be a call to use it in pubsub (for a pull-mode subscription) or storage (does it have pull-mode change notification?). I don't really see it as a blocker for this PR, though.

dhermes · 2015-07-24T00:38:58Z

Pull idiom not a blocker for this PR, but maybe we should file a tracking issue?

As for the rest, the question is about the appropriate name for the variable, not about the feature. I already understood the URI from your previous comment.

object_name does not capture the possibility of a group of files (via a glob) so I'm proposing we consider object_names or object_expression as the variable name.

tseaver · 2015-07-24T00:44:26Z

object_names doesn't work -- it implies a sequence. object_name_glob, maybe?

dhermes · 2015-07-24T00:46:22Z

It's rightly a regex, yes?

tseaver · 2015-07-24T00:47:47Z

Nope (there is no preceding ., for instance). It really is a prefix-only glob pattern.

dhermes · 2015-07-24T00:49:11Z

OK. SGTM.

Change it to your choice of more descriptive variable name and LGTM.

@dhermes

Addresses feedback from @dhermes on #1014.

tseaver · 2015-07-24T14:50:41Z

@dhermes 48eef92 changes the argument name to object_name_glob.

dhermes · 2015-07-24T14:55:09Z

SGTM. We're all good to merge then, right?

tseaver · 2015-07-24T14:55:22Z

Yup

Add usage docs for jobs: query and load.

Fixes #1014 and unblocks #1043. NOTE: Some real world APIs expect the first request to pass a config (example) so the generated samples will not work out of the box. This will be addressed when the new sample config language is sorted out.

* fix: fix thread cleanup when destroying Watch instance * added test for on_snapshot while closing

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Issue discovered while investigating what properties are needed in #967

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.3 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>pandas-gbq: v0.34.0</summary> ## [v0.34.0](googleapis/python-bigquery-pandas@v0.33.0...v0.34.0) (2026-03-05) ### Features * support biglake tables in pandas_gbq.sample (#1014) ([16d08696](googleapis/python-bigquery-pandas@16d08696)) ### Bug Fixes * support pandas 3.0 (prerelease) (#998) ([4ea2d57f](googleapis/python-bigquery-pandas@4ea2d57f)) ### Documentation * Update bigframes links to new homepage (#1028) ([72f772ec](googleapis/python-bigquery-pandas@72f772ec)) </details>

Add usage docs for jobs: query and load.

8415655

tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 23, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2015

dhermes reviewed Jul 23, 2015
View reviewed changes

Comment thread docs/bigquery-usage.rst Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits July 23, 2015 13:44

Typo fixes.

02f4a92

Addresses feedback from @dhermes on #1014.

Bound polling loops.

31f083c

Addresses feedback from @dhermes in #1014.

Avoid 'f' as variable name. pass mode to 'open'.

9f07efd

Addresses feedback from @dhermes in #1014.

dhermes reviewed Jul 23, 2015
View reviewed changes

Comment thread docs/bigquery-usage.rst Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver mentioned this pull request Jul 23, 2015

Add examples for browsing / copying / exporting table data. #1016

Merged

Give argument a more descriptive name.

48eef92

Addresses feedback from @dhermes on #1014.

tseaver added a commit that referenced this pull request Jul 24, 2015

Merge pull request #1014 from tseaver/bigquery-devx-jobs-query_load

fd6c48a

Add usage docs for jobs: query and load.

tseaver merged commit fd6c48a into googleapis:master Jul 24, 2015

tseaver deleted the bigquery-devx-jobs-query_load branch July 27, 2015 17:04

dhermes mentioned this pull request Aug 12, 2015

Upgrading version to 0.7.1. #1057

Merged

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore(docs): add execute query docs pages (#1014)

57416c3

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: Watch thread deadlock on exit (#1014)

ee78a03

* fix: fix thread cleanup when destroying Watch instance * added test for on_snapshot while closing

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: support sub-meanings for datastore v2.20.3 (#1014)

74e88ed

parthea pushed a commit that referenced this pull request Mar 2, 2026

chore(docs): add execute query docs pages (#1014)

d3570c5

Conversation

tseaver commented Jul 23, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jul 23, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

dhermes commented Jul 24, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

dhermes commented Jul 24, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

dhermes commented Jul 24, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

dhermes commented Jul 24, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants