Visitar URL original
Using custom named temporary file. by dhermes · Pull Request #1222 · googleapis/google-cloud-python · GitHub
Skip to content

Using custom named temporary file. - #1222

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-namedtemp
Nov 18, 2015
Merged

Using custom named temporary file.#1222
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-namedtemp

Conversation

@dhermes

@dhermes dhermes commented Nov 16, 2015

Copy link
Copy Markdown
Contributor

This is so that tests can run successfully on Windows.

In addition, using generic integer types (from six) for gcloud._helpers._millis_from_datetime since it returns a long on Windows and int on Linux. Also monkey patching the GCE ID check in test_ctor_w_dataset_id_no_environ since some CI environments will give a "false positive" on that test.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2015
tseaver
tseaver reviewed Nov 17, 2015
View reviewed changes
Comment thread gcloud/storage/test_blob.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Using custom named temporary file.
85d8371 
This is so that tests can run successfully on Windows.

In addition, using generic integer types (from `six`)
for `gcloud._helpers._millis_from_datetime` since it returns
a `long` on Windows and `int` on Linux. Also monkey
patching the GCE ID check in `test_ctor_w_dataset_id_no_environ`
since some CI environments will give a "false positive"
on that test.
@tseaver

tseaver commented Nov 18, 2015

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Nov 18, 2015
@dhermes
Merge pull request #1222 from dhermes/drop-namedtemp
1d1c8a2 
Using custom named temporary file.
@dhermes
dhermes merged commit 1d1c8a2 into googleapis:master Nov 18, 2015
@dhermes
dhermes deleted the drop-namedtemp branch November 18, 2015 20:29
@tseaver tseaver mentioned this pull request Nov 18, 2015
Merged
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
@dhermes dhermes mentioned this pull request Jun 17, 2016
Closed
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 0.63.5 (#1222)
0091f36 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@BigTailWolf
chore: update token (#1222)
0f7f588
parthea pushed a commit that referenced this pull request Mar 6, 2026
@abecerrilsalas
feat: support using BIGQUERY_EMULATOR_HOST environment variable (#1222)
93cfc6a 
* feat:adding emulator

* apb_feature_bq_emulator_test

* apb_feature_bq_emulator_variable_name_change

* abecerrilsalas_feature_bq_emulator_typo_changes

* feat:fixing var names and start of test

* abecerrilsalas_feature_additional_tests

* feat: testing update

* feat: fixed failed lint test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot