Visitar URL original
Adding property to get a table identifier for a query. by dhermes · Pull Request #1254 · googleapis/google-cloud-python · GitHub
Skip to content

Adding property to get a table identifier for a query. - #1254

Closed
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:bigquery-name-brackets
Closed

Adding property to get a table identifier for a query.#1254
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:bigquery-name-brackets

Conversation

@dhermes

@dhermes dhermes commented Dec 1, 2015

Copy link
Copy Markdown
Contributor

Also updating BigQuery usage docs to use the correct form of table identifier in a query string.

@dhermes
Adding property to get a table identifier for a query.
f3c0d08 
Also updating BigQuery usage docs to use the correct form of
table identifier in a query string.
@dhermes dhermes added the api: bigquery Issues related to the BigQuery API. label Dec 1, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2015
@dhermes

dhermes commented Dec 1, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver I'm not sure if this is necessary? Maybe we should just modify table_id or something else?

dhermes
dhermes reviewed Dec 1, 2015
View reviewed changes
Comment thread docs/bigquery-usage.rst

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Dec 1, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Here is an example

>>> table.table_id
u'omega-moonlight-697:timestamp_test.test'
>>> table.query_id
'[omega-moonlight-697:timestamp_test.test]'
>>> table.query_id == '[' + table.table_id + ']'
True

tseaver
tseaver reviewed Dec 1, 2015
View reviewed changes
Comment thread gcloud/bigquery/test_table.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Bump

@tseaver

tseaver commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

Did you plan to update the test expected value generation? I don't see any reasonable chance that the project / dataset / table will be bytes.

@dhermes

dhermes commented Dec 10, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Let's just kill this PR. It was inspired by a farse (me not waiting long enough for results to come back).

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2015
@tseaver tseaver closed this Dec 10, 2015
@dhermes
dhermes deleted the bigquery-name-brackets branch December 10, 2015 15:20
atulep pushed a commit that referenced this pull request Apr 6, 2023
michaelawyu @busunkim96
Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleC…
d149033 
…loudPlatform/python-docs-samples#1254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot