Visitar URL original
Updating datastore system test to allow concurrent runs. by dhermes · Pull Request #1370 · googleapis/google-cloud-python · GitHub
Skip to content

Updating datastore system test to allow concurrent runs. - #1370

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-system-test-namespace
Jan 14, 2016
Merged

Updating datastore system test to allow concurrent runs.#1370
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-system-test-namespace

Conversation

@dhermes

@dhermes dhermes commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

Using a namespace for any key which is changed (inserted/deleted) so that concurrent tests don't operate on the same data. The one exception is TestDatastoreQuery which depends on entities which need to be already stored and indexed before running. For this test case, a new client is created without any namespace.

NOTE: Has #1369 as diffbase.

Inspired by #1363.

@dhermes dhermes added api: datastore Issues related to the Datastore API. testing labels Jan 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2016
@dhermes
dhermes force-pushed the ds-system-test-namespace branch from 88abb42 to 4d5b224 Compare January 8, 2016 21:34
This was referenced Jan 8, 2016
Merged
Merged
tseaver
tseaver reviewed Jan 14, 2016
View reviewed changes
Comment thread system_tests/datastore.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Jan 14, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver FYI #1383 should be merged before this.

@dhermes
dhermes force-pushed the ds-system-test-namespace branch 2 times, most recently from 4cbeada to 49f8a23 Compare January 14, 2016 21:13
@dhermes

dhermes commented Jan 14, 2016

Copy link
Copy Markdown
Contributor Author

LuLz. Pushed a test key.

@dhermes
Updating datastore system test to allow concurrent runs.
6d85a03 
Using a namespace for any key which is changed (inserted/deleted)
so that concurrent tests don't operate on the same data. The
one exception is `TestDatastoreQuery` which depends on entities
which need to be already stored and indexed before running. For
this test case, a new client is created without any namespace.
@dhermes
dhermes force-pushed the ds-system-test-namespace branch from 49f8a23 to 6d85a03 Compare January 14, 2016 21:15
dhermes
dhermes reviewed Jan 14, 2016
View reviewed changes
Comment thread system_tests/datastore.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes added a commit that referenced this pull request Jan 14, 2016
@dhermes
Merge pull request #1370 from dhermes/ds-system-test-namespace
aca137f 
Updating datastore system test to allow concurrent runs.
@dhermes
dhermes merged commit aca137f into googleapis:master Jan 14, 2016
@dhermes
dhermes deleted the ds-system-test-namespace branch January 14, 2016 21:28
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 9, 2026
@olavloite
build: reduce build time (#1370)
c767cea 
* build: reduce build time

* build: move some checks to GitHub Actions

* test: speed up more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot