Visitar URL original
feat(storage): support storage_class via Blob in AsyncAppendableObjectWriter by chandra-siri · Pull Request #18318 · googleapis/google-cloud-python · GitHub
Skip to content

feat(storage): support storage_class via Blob in AsyncAppendableObjectWriter - #18318

Merged
chandra-siri merged 16 commits into
googleapis:mainfrom
chandra-siri:feat/storage-class-via-blob
Sep 23, 2026
Merged

feat(storage): support storage_class via Blob in AsyncAppendableObjectWriter#18318
chandra-siri merged 16 commits into
googleapis:mainfrom
chandra-siri:feat/storage-class-via-blob

Conversation

@chandra-siri

@chandra-siri chandra-siri commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Adds support for propagating storage_class when creating an AsyncAppendableObjectWriter via AsyncAppendableObjectWriter.from_blob(client, blob), mapping storage_class in _grpc_conversions.blob_to_proto, and updating system and unit tests accordingly.

Changes

  • Conversions & Writer:
    • Added "storage_class": "storage_class" to _BLOB_ATTR_TO_PROTO_FIELD in _grpc_conversions.py.
    • Added storage_class=blob.storage_class in AsyncAppendableObjectWriter.from_blob.
  • Unit Tests:
    • Added unit tests for storage_class mapping in test__grpc_conversions.py.
    • Added unit tests for storage_class handling in AsyncAppendableObjectWriter.from_blob in test_async_appendable_object_writer.py.
  • System Tests:
    • Enabled test_write_from_blob and test_write_blob_with_contexts under RCU by setting blob.storage_class = "RAPID" when RCU_SYSTEM_TESTS is active.

@chandra-siri
feat(storage): support storage_class in AsyncAppendableObjectWriter
e2eab99 
Add support for specifying storage_class when writing objects via AsyncAppendableObjectWriter.

- Add storage_class parameter to AsyncAppendableObjectWriter.__init__ and
  propagate it to _AsyncWriteObjectStream on open().
- Add storage_class parameter to _AsyncWriteObjectStream.__init__ and pass it
  to _storage_v2.Object creation.
- Add unit tests covering initialization and open stream requests.
@chandra-siri
test(storage): support preprod endpoints and RCU system tests
9797d34
@chandra-siri
test(storage): update zonal system tests for RCU and storage_class
41a8d06
@chandra-siri
style(storage): fix import ordering of ClientOptions in system tests
8a67130
@chandra-siri
add doc string in test_zonal.py
2840244
@chandra-siri
feat(storage): support storage_class via Blob in AsyncAppendableObjec…
6da285c 
…tWriter
@chandra-siri
chandra-siri requested a review from a team as a code owner September 9, 2026 11:01
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for specifying the storage_class (such as RAPID for RCU system tests) in asynchronous object writers and streams, along with corresponding unit and system test updates. The review feedback highlights two key improvements: first, ensuring that storage_class is respected in _AsyncWriteObjectStream even when a blob is present, and second, replacing the XOR operator with or in the system test skipif condition to prevent tests from being incorrectly skipped when both Zonal and RCU tests are enabled.

Comment thread packages/google-cloud-storage/google/cloud/storage/asyncio/async_write_object_stream.py Resolved
Comment thread packages/google-cloud-storage/tests/system/test_zonal.py Resolved
cpriti-os
cpriti-os requested changes Sep 10, 2026
View reviewed changes
Comment thread packages/google-cloud-storage/google/cloud/storage/asyncio/async_appendable_object_writer.py Resolved
Comment thread packages/google-cloud-storage/google/cloud/storage/asyncio/async_write_object_stream.py Resolved
Comment thread packages/google-cloud-storage/tests/unit/asyncio/test_async_appendable_object_writer.py Resolved
nidhiii-27
nidhiii-27 requested changes Sep 21, 2026
View reviewed changes
Comment thread packages/google-cloud-storage/tests/system/conftest.py Resolved
Comment thread packages/google-cloud-storage/tests/unit/asyncio/test_async_appendable_object_writer.py Resolved
@chandra-siri

chandra-siri commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun(82a0478)

@chandra-siri
chandra-siri enabled auto-merge (squash) September 23, 2026 07:14
@chandra-siri
chandra-siri merged commit b0872f2 into googleapis:main Sep 23, 2026
47 of 48 checks passed
@release-please release-please Bot mentioned this pull request Sep 23, 2026
Merged
sofisl pushed a commit that referenced this pull request Sep 24, 2026
@release-please
chore: release main (#18421)
c0208c6 
🤖 I have created a release *beep* *boop*
---


<details><summary>gapic-generator: 1.40.0</summary>

##
[1.40.0](gapic-generator-v1.39.0...gapic-generator-v1.40.0)
(2026-09-24)


### Features

* add 3.15 support to gapic library classifiers
([#18450](#18450))
([5fe1ef3](5fe1ef3))


### Bug Fixes

* **bazel:** allow CustomProtoInfo in gapic_compat_proto_library
([#18417](#18417))
([11bdf92](11bdf92))
</details>

<details><summary>google-ads-marketingplatform-admin: 0.6.1</summary>

##
[0.6.1](google-ads-marketingplatform-admin-v0.6.0...google-ads-marketingplatform-admin-v0.6.1)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-analytics-data: 0.23.2</summary>

##
[0.23.2](google-analytics-data-v0.23.1...google-analytics-data-v0.23.2)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-api-core: 2.39.0</summary>

##
[2.39.0](google-api-core-v2.38.0...google-api-core-v2.39.0)
(2026-09-24)


### Features

* **google-api-core:** add support for resumable uploads
([#18352](#18352))
([17d6c53](17d6c53))
</details>

<details><summary>google-apps-chat: 0.10.6</summary>

##
[0.10.6](google-apps-chat-v0.10.5...google-apps-chat-v0.10.6)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-agentregistry: 0.1.1</summary>

##
[0.1.1](google-cloud-agentregistry-v0.1.0...google-cloud-agentregistry-v0.1.1)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-bigtable: 2.47.0</summary>

##
[2.47.0](google-cloud-bigtable-v2.46.0...google-cloud-bigtable-v2.47.0)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-firestore: 2.32.0</summary>

##
[2.32.0](google-cloud-firestore-v2.31.0...google-cloud-firestore-v2.32.0)
(2026-09-24)


### Features

* **firestore:** add BSONBinary support
([#18389](#18389))
([85556ad](85556ad))
* **firestore:** add BSONDecimal128 support
([#18395](#18395))
([a04c831](a04c831))
* **firestore:** add BSONRegex support
([#18394](#18394))
([322c9bc](322c9bc))
* **firestore:** add BSONTimestamp support
([#18390](#18390))
([a1b2d63](a1b2d63))
</details>

<details><summary>google-cloud-geminidataanalytics: 0.13.4</summary>

##
[0.13.4](google-cloud-geminidataanalytics-v0.13.3...google-cloud-geminidataanalytics-v0.13.4)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-lustre: 0.4.2</summary>

##
[0.4.2](google-cloud-lustre-v0.4.1...google-cloud-lustre-v0.4.2)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-monitoring-dashboards: 3.1.0</summary>

##
[3.1.0](google-cloud-monitoring-dashboards-v3.0.0...google-cloud-monitoring-dashboards-v3.1.0)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-ndb: 2.6.1</summary>

##
[2.6.1](google-cloud-ndb-v2.6.0...google-cloud-ndb-v2.6.1)
(2026-09-24)


### Bug Fixes

* **google-cloud-ndb:** allow redis 8.x
([#18438](#18438))
([9630fe4](9630fe4))
</details>

<details><summary>google-cloud-parametermanager: 0.4.2</summary>

##
[0.4.2](google-cloud-parametermanager-v0.4.1...google-cloud-parametermanager-v0.4.2)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-storage: 3.15.0</summary>

##
[3.15.0](google-cloud-storage-v3.14.1...google-cloud-storage-v3.15.0)
(2026-09-24)


### Features

* **storage:** support storage_class in AsyncAppendableObjectWriter
([#18289](#18289))
([dc30df2](dc30df2))
* **storage:** support storage_class via Blob in
AsyncAppendableObjectWriter
([#18318](#18318))
([b0872f2](b0872f2))
</details>

<details><summary>google-cloud-tasks: 2.25.0</summary>

##
[2.25.0](google-cloud-tasks-v2.24.0...google-cloud-tasks-v2.25.0)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>google-cloud-vectorsearch: 0.11.4</summary>

##
[0.11.4](google-cloud-vectorsearch-v0.11.3...google-cloud-vectorsearch-v0.11.4)
(2026-09-24)


### Features

* update API sources and regenerate
([#18446](#18446))
([54f1019](54f1019))
</details>

<details><summary>googleapis-common-protos: 1.75.4</summary>

##
[1.75.4](googleapis-common-protos-v1.75.3...googleapis-common-protos-v1.75.4)
(2026-09-24)


### Bug Fixes

* regenerate gencode with protobuf 6.33.5
([#18461](#18461))
([9cb21d0](9cb21d0))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpriti-os cpriti-os cpriti-os approved these changes
@nidhiii-27 nidhiii-27 nidhiii-27 approved these changes
@ShreyasSinha ShreyasSinha Awaiting requested review from ShreyasSinha
@shradhakatyal shradhakatyal Awaiting requested review from shradhakatyal
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cpriti-os cpriti-os

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chandra-siri @cpriti-os @nidhiii-27