Visitar URL original
Add customer-supplied encryption to storage by daspecster · Pull Request #1844 · googleapis/google-cloud-python · GitHub
Skip to content

Add customer-supplied encryption to storage - #1844

Merged
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:customer-supplied-encryption
Jun 15, 2016
Merged

Add customer-supplied encryption to storage#1844
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:customer-supplied-encryption

Conversation

@daspecster

@daspecster daspecster commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Possible solution to resolve #1841.

I think my tests could use some feedback.

@daspecster daspecster added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Jun 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2016
@daspecster
daspecster force-pushed the customer-supplied-encryption branch from 0d91e0b to f713c3e Compare June 7, 2016 19:53
@daspecster

daspecster commented Jun 7, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver @dhermes PTAL when you have a moment.

dhermes
dhermes reviewed Jun 8, 2016
View reviewed changes
Comment thread gcloud/storage/blob.py Outdated
"""
return bucket_path + '/o/' + quote(blob_name, safe='')

@staticmethod

This comment was marked as spam.

Sign in to view

@daspecster
daspecster force-pushed the customer-supplied-encryption branch 2 times, most recently from 737bf7e to bfaf049 Compare June 8, 2016 20:04
@daspecster

daspecster commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes I think I got your comments addressed.
@tseaver Let me know what you think as well.

dhermes
dhermes reviewed Jun 9, 2016
View reviewed changes
Comment thread gcloud/_helpers.py

:type value: bytes
:param value: bytes value to attempt string conversion on.
"""

This comment was marked as spam.

Sign in to view

@daspecster
daspecster force-pushed the customer-supplied-encryption branch from b4152a2 to 824bf93 Compare June 10, 2016 11:27
@daspecster

daspecster commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes I squashed the commits for this. Let me know if you have any other feedback.

jgeewax
jgeewax reviewed Jun 10, 2016
View reviewed changes
Comment thread gcloud/_helpers.py Outdated
raise TypeError('%r could not be converted to bytes' % (value,))


def _from_bytes(value):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support custom encryption keys

4 participants

@daspecster @jgeewax @dhermes @googlebot