Visitar URL original
Update PyLint config for latest version. by dhermes · Pull Request #2396 · googleapis/google-cloud-python · GitHub
Skip to content

Update PyLint config for latest version. - #2396

Merged
dhermes merged 11 commits into
googleapis:masterfrom
dhermes:update-pylint-config
Sep 23, 2016
Merged

Update PyLint config for latest version.#2396
dhermes merged 11 commits into
googleapis:masterfrom
dhermes:update-pylint-config

Conversation

@dhermes

@dhermes dhermes commented Sep 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1256.

This PR diff will probably just look like a giant splat. I went through this process with tiny commits to make the review easier. I started with the default config side-by-side with ours. Then I narrowed down ours to only edited values. Then I moved over those edited values a few at a time.

Worth noting: My main goal was to be able to increase jobs=1 after this PR is merged, to speed up PyLint.

@dhermes
Adding the default PyLint config with the latest version.
682eafa 
Done via:

$ pylint --version
No config file found, using default configuration
pylint 1.6.4,
astroid 1.4.8
Python 2.7.12 (default, Jul 17 2016, 01:21:14)
[GCC 4.8.4]
$ pylint --generate-rcfile > scripts/pylintrc_v1.6.4_default
@dhermes
Removing all defaults from current Pylint RC.
0691a17 
This is to make it easier to move defaults over to the
newly generated file.
@dhermes
Moving header and master sections of PyLint RC over.
e826c2b
@dhermes
Breaking up the default Pylint disable onto separate lines.
a03e1c5
@dhermes
Moving disable sections of PyLint RC over.
581bf43
@dhermes
Moving reports and format sections of PyLint RC over.
6045732
@dhermes
Moving [BASIC] section of PyLint RC over.
723d75a
@dhermes
Moving [TYPECHECK] section of PyLint RC over.
a75694b
@dhermes
Moving [DESIGN] section of PyLint RC over.
ed86ea6 
This is the final section, hence the original config has
also been deleted.
@dhermes
Renaming the v1.6.4 PyLint config as default.
aee3863
@dhermes
Updating header description in pylint config.
ffc4ddb
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2016
daspecster
daspecster reviewed Sep 23, 2016
View reviewed changes
Comment thread scripts/pylintrc_default

# Specify a configuration file.
# DEFAULT: rcfile=
#rcfile=

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread scripts/pylintrc_default
round-builtin,
hex-method,
nonzero-method,
map-builtin-not-iterating,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread scripts/pylintrc_default

# Bad variable names which should always be refused, separated by a comma
# DEFAULT: bad-names=foo,bar,baz,toto,tutu,tata
bad-names=foo,bar,baz,toto,tutu,tata

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
dhermes merged commit d5bebb8 into googleapis:master Sep 23, 2016
@dhermes
dhermes deleted the update-pylint-config branch September 23, 2016 16:12
@dhermes dhermes mentioned this pull request Sep 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@daspecster daspecster daspecster left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @daspecster @googlebot