Visitar URL original
Updating list_metrics() to Iterator pattern. by dhermes · Pull Request #2653 · googleapis/google-cloud-python · GitHub
Skip to content

Updating list_metrics() to Iterator pattern. - #2653

Merged
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-metrics
Nov 1, 2016
Merged

Updating list_metrics() to Iterator pattern.#2653
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-metrics

Conversation

@dhermes

@dhermes dhermes commented Oct 31, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.

@dhermes dhermes added the api: logging Issues related to the Cloud Logging API. label Oct 31, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016
@dhermes
dhermes force-pushed the logging-iterators-metrics branch 2 times, most recently from fc6e57f to 5b33597 Compare October 31, 2016 23:31
@dhermes

dhermes commented Oct 31, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster @tseaver PTAL

@tseaver

tseaver commented Nov 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

pyilnt failure:

logging/google/cloud/logging/_gax.py:500:1: E303 too many blank lines (3)

@dhermes
dhermes force-pushed the logging-iterators-metrics branch from 5b33597 to ce40029 Compare November 1, 2016 04:46
@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

Ahhhh! Darn rebases. PTAL.

Was that your only issue?

@tseaver

tseaver commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

I didn't really review it in detail since Travis was red.

@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

OK well it's good to go now. LMK what you think

tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
Comment thread logging/unit_tests/test_client.py
returned = {
'metrics': METRICS,
}
client.connection = _Connection(returned)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread logging/unit_tests/test_client.py Outdated
token = iterator.next_page_token

# First check the token.
self.assertIsNone(token)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermes force-pushed the logging-iterators-metrics branch from ce40029 to 9cf835c Compare November 1, 2016 16:24
@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL

@dhermes
dhermes merged commit b4d87f7 into googleapis:master Nov 1, 2016
@dhermes
dhermes deleted the logging-iterators-metrics branch November 1, 2016 16:52
@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2653 from dhermes/logging-iterators-met…
ac63bce 
…rics

Updating list_metrics() to Iterator pattern.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Merge pull request #2653 from dhermes/logging-iterators-metrics
3e86b12 
Updating list_metrics() to Iterator pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @daspecster @googlebot