Visitar URL original
Add 'on_error' argument to 'retry.retry_target' and 'Retry'. by tseaver · Pull Request #3891 · googleapis/google-cloud-python · GitHub
Skip to content

Add 'on_error' argument to 'retry.retry_target' and 'Retry'. - #3891

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:core-retry_target-add-on_error-argument
Aug 29, 2017
Merged

Add 'on_error' argument to 'retry.retry_target' and 'Retry'.#3891
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:core-retry_target-add-on_error-argument

Conversation

@tseaver

@tseaver tseaver commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

Permit application code to reset / fix-up state before retrying.

See: #3889

@tseaver
Add 'on_error' argument to 'retry.retry_target' and 'Retry'.
c14306b 
Permit application code to reset / fix-up state before retrying.

See:
#3889
@tseaver
tseaver requested a review from theacodes August 28, 2017 20:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2017
dhermes
dhermes approved these changes Aug 28, 2017
View reviewed changes

@dhermes dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I think you should let @jonparrott have a look before merging

Comment thread core/google/api/core/retry.py Outdated
sleep_generator (Iterator[float]): An infinite iterator that determines
how long to sleep between retries.
deadline (float): How long to keep retrying the target.
on_error(Callable): A function to call while processing a retryable

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread core/google/api/core/retry.py Outdated

Args:
func (Callable): The callable to add retry behavior to.
on_error(Callable): A function to call while processing a

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread core/tests/unit/api_core/test_retry.py
raise ValueError()
return 42

result = retry.retry_target(

This comment was marked as spam.

Sign in to view

Comment thread core/tests/unit/api_core/test_retry.py

result = retry.retry_target(
target, predicate, range(10), None, on_error=on_error)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

theacodes
theacodes reviewed Aug 28, 2017
View reviewed changes

@theacodes theacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good, just a few questions.

Comment thread core/google/api/core/retry.py Outdated
raise
last_exc = exc
if on_error is not None:
on_error()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread core/google/api/core/retry.py Outdated
sleep_generator (Iterator[float]): An infinite iterator that determines
how long to sleep between retries.
deadline (float): How long to keep retrying the target.
on_error(Callable): A function to call while processing a retryable

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread core/google/api/core/retry.py
self._deadline = deadline

def __call__(self, func):
def __call__(self, func, on_error=None):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes mentioned this pull request Aug 28, 2017
Closed
@theacodes

theacodes commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

This is fine to merge once on_error is passed the exc. Then, @tseaver can use it to make #3889 much simpler.

@tseaver
tseaver merged commit 9c4144b into googleapis:master Aug 29, 2017
@tseaver
tseaver deleted the core-retry_target-add-on_error-argument branch August 29, 2017 14:33
@tseaver tseaver mentioned this pull request Aug 29, 2017
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Add 'on_error' argument to 'retry.retry_target' and 'Retry'. (#3891)
9af18ca 
Permit application code to reset / fix-up state before retrying.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@theacodes theacodes theacodes left review comments
@dhermes dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @theacodes @dhermes @googlebot