Visitar URL original
Add 'Bucket.list_notifications' API wrapper. by tseaver · Pull Request #3990 · googleapis/google-cloud-python · GitHub
Skip to content

Add 'Bucket.list_notifications' API wrapper. - #3990

Merged
tseaver merged 3 commits into
googleapis:3956-storage-notificationsfrom
tseaver:3956-storage-notifications-bucket-list_notifications
Sep 21, 2017
Merged

Add 'Bucket.list_notifications' API wrapper.#3990
tseaver merged 3 commits into
googleapis:3956-storage-notificationsfrom
tseaver:3956-storage-notifications-bucket-list_notifications

Conversation

@tseaver

@tseaver tseaver commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Uses #3983 as a base.

Toward #3956.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 18, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2017
@tseaver tseaver mentioned this pull request Sep 18, 2017
Closed
8 tasks done
dhermes
dhermes reviewed Sep 18, 2017
View reviewed changes
Comment thread storage/google/cloud/storage/bucket.py Outdated
return iterator

def list_notifications(self, client=None):
"""List pubsub notifications for this bucket.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread storage/google/cloud/storage/notification.py Outdated
:returns: the new notification instance
:raises ValueError:
if resource is missing 'topic' key, or if it is not formatted
per documented spec.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread storage/google/cloud/storage/notification.py Outdated
match = _TOPIC_REF_RE.match(topic_path)
if match is None:
raise ValueError(
'Resource has invalid topic: {}'.format(topic_path))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Sep 21, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes Any remaining issues?

dhermes
dhermes approved these changes Sep 21, 2017
View reviewed changes

@dhermes dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver
tseaver merged commit 9eb9a46 into googleapis:3956-storage-notifications Sep 21, 2017
@tseaver
tseaver deleted the 3956-storage-notifications-bucket-list_notifications branch September 21, 2017 19:15
tseaver added a commit that referenced this pull request Sep 25, 2017
@tseaver
Add 'Bucket.list_notifications' API wrapper. (#3990)
352aeed 
Toward #3956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer
1 more reviewer
@dhermes dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @dhermes @googlebot