Visitar URL original
BigQuery: Use DatasetListItem for client.list_datasets by tswast · Pull Request #4439 · googleapis/google-cloud-python · GitHub
Skip to content

BigQuery: Use DatasetListItem for client.list_datasets - #4439

Merged
tswast merged 4 commits into
googleapis:masterfrom
tswast:bq-datasetref
Dec 6, 2017
Merged

BigQuery: Use DatasetListItem for client.list_datasets#4439
tswast merged 4 commits into
googleapis:masterfrom
tswast:bq-datasetref

Conversation

@tswast

@tswast tswast commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

Listing datasets only includes a subset of the properties available on a
dataset. The DatasetListItem class is used to explicitly document which
features are available and to prevent confusion from trying to use the
resulting object in other contexts, like updating.

Closes #4373.

@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Nov 22, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2017
@tswast
tswast requested a review from theacodes November 29, 2017 23:43
@tswast

tswast commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

Ping. Please review.

tswast added 2 commits December 4, 2017 16:51
@tswast
BigQuery: Use DatasetListItem for client.list_datasets
72079dc 
Listing datasets only includes a subset of the properties available on a
dataset. The DatasetListItem class is used to explicitly document which
features are available and to prevent confusion from trying to use the
resulting object in other contexts, like updating.
@tswast
Fix lint errors.
c5dcbd6
tseaver
tseaver suggested changes Dec 5, 2017
View reviewed changes
Comment thread bigquery/google/cloud/bigquery/dataset.py Outdated
:rtype: str
:returns: the project.
"""
return self._properties.get('datasetReference').get('projectId')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread bigquery/google/cloud/bigquery/dataset.py Outdated
:rtype: str
:returns: the dataset ID.
"""
return self._properties.get('datasetReference').get('datasetId')

This comment was marked as spam.

Sign in to view

Comment thread bigquery/google/cloud/bigquery/dataset.py Outdated
:rtype: dict, {str -> str}
:returns: A dict of the the dataset's labels.
"""
return self._properties['labels']

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tswast
tswast merged commit cc852af into googleapis:master Dec 6, 2017
@tswast
tswast deleted the bq-datasetref branch December 6, 2017 00:09
@tseaver tseaver mentioned this pull request Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer
@dhermes dhermes Awaiting requested review from dhermes
@theacodes theacodes Awaiting requested review from theacodes
1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @tseaver @googlebot