Visitar URL original
BigQuery: Add Client.insert_rows, deprecate Client.create_rows by tswast · Pull Request #4657 · googleapis/google-cloud-python · GitHub
Skip to content

BigQuery: Add Client.insert_rows, deprecate Client.create_rows - #4657

Merged
tswast merged 4 commits into
googleapis:masterfrom
tswast:bq-insert-rows
Jan 2, 2018
Merged

BigQuery: Add Client.insert_rows, deprecate Client.create_rows#4657
tswast merged 4 commits into
googleapis:masterfrom
tswast:bq-insert-rows

Conversation

@tswast

@tswast tswast commented Dec 22, 2017

Copy link
Copy Markdown
Contributor

insert_rows aligns better with API request (Tabledata.insertAll). Feedback from BQ GA review.

Note that the create_rows() sample in the Python migration guide already points to a commit hash, so this should be safe to merge whenever.

@tswast
BigQuery: Add Client.insert_rows, deprecate Client.create_rows
42de2a2 
`insert_rows` aligns better with API request (Tabledata.insertAll).
Feedback from BQ GA review.
@tswast
Merge remote-tracking branch 'upstream/master' into bq-insert-rows
4cfcef2
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2017
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jan 2, 2018
dhermes
dhermes approved these changes Jan 2, 2018
View reviewed changes

@dhermes dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
tswast merged commit 55df6a2 into googleapis:master Jan 2, 2018
@tswast
tswast deleted the bq-insert-rows branch January 2, 2018 19:15
tseaver
tseaver reviewed Jan 2, 2018
View reviewed changes
Comment thread bigquery/tests/system.py
body, table, job_config=job_config).result()

df = Config.CLIENT.list_rows(
table, selected_fields=schema).to_dataframe()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread docs/bigquery/snippets.py
to_delete.insert(0, table_ref)
# Load a table using a local JSON file from memory.
client.load_table_from_file(
body, table_ref, job_config=job_config).result()

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer
2 more reviewers
@tseaver tseaver tseaver left review comments
@dhermes dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast @tseaver @dhermes @googlebot