Visitar URL original
feat(billingbudgets): initial generation of billing budget by busunkim96 · Pull Request #9622 · googleapis/google-cloud-python · GitHub
Skip to content

feat(billingbudgets): initial generation of billing budget - #9622

Merged
busunkim96 merged 4 commits into
googleapis:masterfrom
busunkim96:billing-budget-v1beta1
Nov 14, 2019
Merged

feat(billingbudgets): initial generation of billing budget#9622
busunkim96 merged 4 commits into
googleapis:masterfrom
busunkim96:billing-budget-v1beta1

Conversation

@busunkim96

@busunkim96 busunkim96 commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2019
@busunkim96 busunkim96 changed the title feat(billingbudgets): initial generation of billing budget v1beta1 feat(billingbudgets): initial generation of billing budget Nov 6, 2019
@busunkim96
busunkim96 requested a review from a team November 7, 2019 00:11
tseaver
tseaver suggested changes Nov 7, 2019
View reviewed changes
Comment thread billingbudgets/README.rst
@@ -0,0 +1,75 @@
Python Client for Cloud Billing Budget API (`Alpha`_)
=====================================================

@tseaver tseaver Nov 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a top-level summary description.

@busunkim96 busunkim96 Nov 7, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

billingbudgets.yaml is missing a summary line. I've asked the API team to add one.

@tseaver tseaver Nov 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to wait on that change and update the PR with the same text?

@busunkim96 busunkim96 Nov 11, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'll keep this open until I see the change to the protos

Comment thread billingbudgets/docs/README.rst Resolved
Comment thread billingbudgets/.repo-metadata.json Resolved
Comment thread billingbudgets/README.rst Resolved
Comment thread billingbudgets/README.rst Resolved
Comment thread billingbudgets/README.rst Resolved
Comment thread billingbudgets/setup.py Resolved
@busunkim96
busunkim96 force-pushed the billing-budget-v1beta1 branch from 8faa130 to c054f77 Compare November 7, 2019 21:22
@busunkim96
busunkim96 merged commit 6751237 into googleapis:master Nov 14, 2019
@busunkim96
busunkim96 deleted the billing-budget-v1beta1 branch November 14, 2019 20:42
This was referenced Jan 29, 2020
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
feat(billingbudgets): initial generation of billing budget (#9622)
7d985c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96 @tseaver @googlebot